Performance.measure: handle the case with a single startMark argument correctly #37888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46728261 |
… correctly (facebook#37888) Summary: Pull Request resolved: facebook#37888 # Changelog: [Internal] - There was one particular permutation of input arguments to `Performance.measure` that wasn't handled correctly on the native side, namely when there is only the start mark argument present, but not the end time/mark, e.g.: ``` Performance.measure('myMeasure', 'someStartMark'); ``` In this case, [according to the standard](https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure), the end time should be taken as the current one: > The end timestamp is one of: > ... > -the value returned by Performance.now(), if no end mark is specified or can be determined from other values. It was taken as 0 instead, making the total duration negative and consequently getting it filtered out by the default `durationThreshold` of 0. I've added a corresponding missing clause in the native unit tests. This also required a slight extension to the `PerformanceObserver` API to allow for mocking the current timestamp provider. Reviewed By: rubennorte Differential Revision: D46728261 fbshipit-source-id: fcfcb355d13ce90babceeac398b53de914f1eb35
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46728261 |
Base commit: b3cc19c |
Contributor
|
This pull request has been merged in 4475572. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelist
[Internal] -
There was one particular permutation of input arguments to
Performance.measurethat wasn't handled correctly on the native side, namely when there is only the start mark argument present, but not the end time/mark, e.g.:In this case, according to the standard, the end time should be taken as the current one:
It was taken as 0 instead, making the total duration negative and consequently getting it filtered out by the default
durationThresholdof 0.I've added a corresponding missing clause in the native unit tests. This also required a slight extension to the
PerformanceObserverAPI to allow for mocking the current timestamp provider.Differential Revision: D46728261