Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Nullable annotations to ViewUtils #37877

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Jun 14, 2023

Summary:

Changelog:

[Internal] -

A quick follow-up to #37851

There was a suggestion to add Nullable annotations, but the change had already landed at that point, so putting up another one.

Differential Revision: D46721095

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46721095

@analysis-bot
Copy link

analysis-bot commented Jun 14, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,757,667 -2
android hermes armeabi-v7a 8,070,235 -1
android hermes x86 9,250,264 -1
android hermes x86_64 9,099,402 -4
android jsc arm64-v8a 9,318,867 -3
android jsc armeabi-v7a 8,508,770 -3
android jsc x86 9,382,359 -2
android jsc x86_64 9,635,604 -3

Base commit: be34852
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46721095

rshest added a commit to rshest/react-native that referenced this pull request Jun 14, 2023
Summary:
Pull Request resolved: facebook#37877

# Changelog:
[Internal] -

A quick follow-up to facebook#37851

There was a suggestion to add `Nullable` annotations, but the change had already landed at that point, so putting up another one.

Reviewed By: cortinico

Differential Revision: D46721095

fbshipit-source-id: f334cf88712c4aa156852e57284713762d8b460b
@rshest rshest force-pushed the export-D46721095 branch from d4bb5c8 to 6fe8db0 Compare June 14, 2023 15:19
Summary:
Pull Request resolved: facebook#37877

# Changelog:
[Internal] -

A quick follow-up to facebook#37851

There was a suggestion to add `Nullable` annotations, but the change had already landed at that point, so putting up another one.

Reviewed By: cortinico

Differential Revision: D46721095

fbshipit-source-id: b6565620171cf28103b2da9316af77d286ae0488
@rshest rshest force-pushed the export-D46721095 branch from 6fe8db0 to 76918e2 Compare June 14, 2023 15:33
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46721095

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b3cc19c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants