Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOCAL] Set kotlin.jvm.target.validation.mode=warning on user projects #37869

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

cortinico
Copy link
Contributor

@cortinico cortinico commented Jun 13, 2023

Summary:

This is a fix for reactwg/react-native-releases#54 (comment)
It sets kotlin.jvm.target.validation.mode=warning so that projects won't break if they're using Kotlin 1.8+ and have JDK versions misaligned due to external libraries.

This doens't need to be backported to main as on main we set jvmToolchain(11) for all the libraries so this flag is unnecessary.

Also this is not a .0 blocker and can land in .1

Also this requires a bump of RNGP

Changelog:

[INTERNAL] - Set kotlin.jvm.target.validation.mode=warning on user projects

Test Plan:

Tested locally with ./gradlew build.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 13, 2023
@cipolleschi cipolleschi merged commit e4f6a92 into 0.72-stable Jun 14, 2023
@cipolleschi cipolleschi deleted the nc/kotlin.jvm.target.validation.mode=warn branch June 14, 2023 14:24
@cipolleschi cipolleschi restored the nc/kotlin.jvm.target.validation.mode=warn branch June 14, 2023 15:37
cipolleschi added a commit that referenced this pull request Jun 14, 2023
@cortinico
Copy link
Contributor Author

@kelset has this been reverted (#37885) and the release branch force-pushed?

@kelset
Copy link
Contributor

kelset commented Jun 26, 2023

@cortinico yes - we had to clean up the branch ahead of 0.72.0. I'll take care of manually reapplying in the branch once we start working on 0.72.1

@cortinico
Copy link
Contributor Author

@cortinico yes - we had to clean up the branch ahead of 0.72.0. I'll take care of manually reapplying in the branch once we start working on 0.72.1

In the future, I would suggest we avoid to force push on release branches (we can add a branch protection against force push, for security reasons also) and instead just add a revert commit.

@cortinico cortinico deleted the nc/kotlin.jvm.target.validation.mode=warn branch August 7, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants