Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader #37867

Closed
wants to merge 1 commit into from
Closed

Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader #37867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions packages/react-native/Libraries/Components/ScrollView/ScrollViewStickyHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,17 +262,7 @@ const ScrollViewStickyHeaderWithForwardedRef: React.AbstractComponent<

const child = React.Children.only<$FlowFixMe>(props.children);

// TODO T68319535: remove this if NativeAnimated is rewritten for Fabric
const passthroughAnimatedPropExplicitValues =
isFabric && translateY != null
? {
style: {transform: [{translateY: translateY}]},
}
: null;

return (
/* $FlowFixMe[prop-missing] passthroughAnimatedPropExplicitValues isn't properly
included in the Animated.View flow type. */
<Animated.View
collapsable={false}
nativeID={props.nativeID}
Expand All @@ -282,10 +272,7 @@ const ScrollViewStickyHeaderWithForwardedRef: React.AbstractComponent<
child.props.style,
styles.header,
{transform: [{translateY: animatedTranslateY}]},
]}
passthroughAnimatedPropExplicitValues={
passthroughAnimatedPropExplicitValues
}>
]}>
{React.cloneElement(child, {
style: styles.fill, // We transfer the child style to the wrapper.
onLayout: undefined, // we call this manually through our this._onLayout
Expand Down