Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: border width top/bottom not matching the border radius" #37840

Closed

Conversation

gabrieldonadel
Copy link
Collaborator

Summary:

In an effort to fix #37753, this PR reverts the changes introduced by cd6a913 and 1d51032 so border-radius width calculations work as expected

Changelog:

[ANDROID] [FIXED] - Fix border-radius width calculations

Test Plan:

Test border colors along with border-radius through RNTester
image

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner labels Jun 13, 2023
@gabrieldonadel gabrieldonadel changed the title Fix Android border radius width calculations Revert "fix: border width top/bottom not matching the border radius" Jun 13, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,753,245 -492
android hermes armeabi-v7a 8,065,823 -486
android hermes x86 9,245,849 -486
android hermes x86_64 9,094,992 -481
android jsc arm64-v8a 9,315,643 -635
android jsc armeabi-v7a 8,505,542 -633
android jsc x86 9,379,123 -644
android jsc x86_64 9,632,365 -640

Base commit: 83d7a48
Branch: main

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm that this addresses the border problem we have been hitting in 0.72, see here for screenshots

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 13, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 9c9945a.

@gabrieldonadel gabrieldonadel deleted the fix-border-calcs branch June 13, 2023 14:44
kelset pushed a commit that referenced this pull request Jun 13, 2023
…37840)

Summary:
In an effort to fix #37753, this PR reverts the changes introduced by cd6a913 and 1d51032 so border-radius width calculations work as expected

## Changelog:

[ANDROID] [FIXED] - Fix border-radius width calculations

Pull Request resolved: #37840

Test Plan:
Test border colors along with border-radius through RNTester
<img width="538" alt="image" src="https://github.com/facebook/react-native/assets/11707729/4b148d4b-35dc-4737-be00-c5ff156b0865">

Reviewed By: dmytrorykun

Differential Revision: D46684071

Pulled By: cipolleschi

fbshipit-source-id: cf7a80d0d63009b457f03d690b632e332a9b4a02
Kudo pushed a commit to expo/react-native that referenced this pull request Jun 15, 2023
…acebook#37840)

Summary:
In an effort to fix facebook#37753, this PR reverts the changes introduced by facebook@cd6a913 and facebook@1d51032 so border-radius width calculations work as expected

## Changelog:

[ANDROID] [FIXED] - Fix border-radius width calculations

Pull Request resolved: facebook#37840

Test Plan:
Test border colors along with border-radius through RNTester
<img width="538" alt="image" src="https://github.com/facebook/react-native/assets/11707729/4b148d4b-35dc-4737-be00-c5ff156b0865">

Reviewed By: dmytrorykun

Differential Revision: D46684071

Pulled By: cipolleschi

fbshipit-source-id: cf7a80d0d63009b457f03d690b632e332a9b4a02
(cherry picked from commit 0817eaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RN 0.72: Broken border colors / radius on Android
5 participants