[RN][iOS] Split hermes-engine podspec in Debug and Release to get rid of PRODUCTION flag #37804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In iOS in OSS, we used to use the PRODUCTION flag to install pods with a Release configuration. This is a non-standard flow which we would like to remove.
The standard flow would only use Xcode Debug/Release configurations and would save the reinstall pods step to every developer.
The last blocker for the removal of this flag was the
hermes-engine
pod which not only has to use different configurations depending on whether it is build for debug or release, but it hasalso to provide different prebuilts for the two setups.
The adopted solution is to split the podspec in three: an high level podspec that depends on the flavour-aware podspecs.
You can look here for the description of the issue and the adopted solution.
Changelog:
[IOS] [CHANGED] - Split Hermes-engine in three subspecs to remove the PRODUCTION flag
Test Plan:
Tested locally in an app created from the template
Tested locally with RNTester
CircleCI