Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS] Split hermes-engine podspec in Debug and Release to get rid of PRODUCTION flag #37804

Closed
wants to merge 2 commits into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

In iOS in OSS, we used to use the PRODUCTION flag to install pods with a Release configuration. This is a non-standard flow which we would like to remove.
The standard flow would only use Xcode Debug/Release configurations and would save the reinstall pods step to every developer.

The last blocker for the removal of this flag was the hermes-engine pod which not only has to use different configurations depending on whether it is build for debug or release, but it has
also to provide different prebuilts for the two setups.

The adopted solution is to split the podspec in three: an high level podspec that depends on the flavour-aware podspecs.
You can look here for the description of the issue and the adopted solution.

Changelog:

[IOS] [CHANGED] - Split Hermes-engine in three subspecs to remove the PRODUCTION flag

Test Plan:

Tested locally in an app created from the template
Tested locally with RNTester
CircleCI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 9, 2023
@cipolleschi cipolleschi force-pushed the cipolleschi/split_hermes_configs branch from 18d7e00 to 06263f3 Compare June 9, 2023 15:36
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/split_hermes_configs branch from 06263f3 to dcc0013 Compare June 9, 2023 15:43
@analysis-bot
Copy link

analysis-bot commented Jun 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,747,778 -57
android hermes armeabi-v7a 8,060,382 -51
android hermes x86 9,239,388 -52
android hermes x86_64 9,089,192 -45
android jsc arm64-v8a 9,310,333 -94
android jsc armeabi-v7a 8,500,272 -89
android jsc x86 9,372,836 -89
android jsc x86_64 9,626,734 -87

Base commit: ef5d92f
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/split_hermes_configs branch 3 times, most recently from fa0001c to ece4825 Compare June 10, 2023 18:35
@cipolleschi cipolleschi force-pushed the cipolleschi/split_hermes_configs branch from ece4825 to 24b7406 Compare June 10, 2023 18:40
@cipolleschi
Copy link
Contributor Author

Abandoning this in favor of #37850

@cipolleschi
Copy link
Contributor Author

This is not relevant anymore

@cortinico cortinico deleted the cipolleschi/split_hermes_configs branch June 10, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants