Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen] Add getObjectProperties function to Parser #37789

Closed

Conversation

gabrieldonadel
Copy link
Collaborator

Summary:

[Codegen 128] This PR add a getObjectProperties function to the Parser interface, which returns the properties of an object represented by a type annotation as requested on #34872

Changelog:

[INTERNAL] [ADDED] - Add getObjectProperties function to codegen Parser

Test Plan:

Run yarn jest react-native-codegen and ensure CI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner labels Jun 9, 2023
@rshest
Copy link
Contributor

rshest commented Jun 9, 2023

Thanks for working on this!

Would it be also possible to add unit tests for this new function, please?

@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Jun 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,747,777 +1
android hermes armeabi-v7a 8,060,379 -1
android hermes x86 9,239,387 +0
android hermes x86_64 9,089,190 +1
android jsc arm64-v8a 9,310,333 +1
android jsc armeabi-v7a 8,500,272 +2
android jsc x86 9,372,837 +3
android jsc x86_64 9,626,732 +1

Base commit: 5cc8cee
Branch: main

@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label Jun 9, 2023
@gabrieldonadel
Copy link
Collaborator Author

Thanks for working on this!

Would it be also possible to add unit tests for this new function, please?

Sure @rshest I've just added a few unit tests

@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 13, 2023
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in b5f5221.

@gabrieldonadel gabrieldonadel deleted the create-getObjectProperties branch June 13, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner Tech: Codegen Related to react-native-codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants