Skip to content

Conversation

@tarunrajput
Copy link
Contributor

Summary:

Changelog:

Part of #34872

Extract buildPropertiesForEvent into parsers-commons.js file. Use the code from either Flow or TypeScript which now should be equal. Delete the original ones and use the newly created method instead of those.

[Internal][Changed]: Extract buildPropertiesForEvent and update callsites

Test Plan:

yarn test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,448 +2
android hermes armeabi-v7a 8,056,569 +3
android hermes x86 9,235,515 +0
android hermes x86_64 9,086,321 +3
android jsc arm64-v8a 9,307,021 +3
android jsc armeabi-v7a 8,496,524 +2
android jsc x86 9,369,010 +3
android jsc x86_64 9,623,915 +1

Base commit: a497882
Branch: main

@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label Jun 7, 2023
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 8, 2023
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in 942bd61.

@tarunrajput tarunrajput deleted the extract-buildPropertiesForEvent branch June 27, 2023 11:12
@tarunrajput tarunrajput restored the extract-buildPropertiesForEvent branch June 27, 2023 11:12
@tarunrajput tarunrajput deleted the extract-buildPropertiesForEvent branch June 27, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tech: Codegen Related to react-native-codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants