Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flow-typed definitions to repo root #37636

Closed
wants to merge 1 commit into from

Conversation

huntie
Copy link
Member

@huntie huntie commented May 31, 2023

Summary:
Moves flow-typed/ directory from packages/react-native/flow-typed/ to the repo root.

  • This is a more suitable location for flow-typed definitions for 3P dependencies to be used across React Native packages.
  • Breaking: We no longer publish these 3P libdefs as part of the react-native package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included flow-typed/ directory from the react-native package

Differential Revision: D46313482

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 31, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46313482

@github-actions
Copy link

github-actions bot commented May 31, 2023

Warnings
⚠️

flow-typed/npm/glob_v7.x.x.js#L4 - flow-typed/npm/glob_v7.x.x.js line 4 – Strings must use singlequote. (quotes)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L5 - flow-typed/npm/react-dom_v17.x.x.js line 5 – 'version' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L7 - flow-typed/npm/react-dom_v17.x.x.js line 7 – 'findDOMNode' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L11 - flow-typed/npm/react-dom_v17.x.x.js line 11 – 'render' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L17 - flow-typed/npm/react-dom_v17.x.x.js line 17 – 'hydrate' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L23 - flow-typed/npm/react-dom_v17.x.x.js line 23 – 'createPortal' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L28 - flow-typed/npm/react-dom_v17.x.x.js line 28 – 'unmountComponentAtNode' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L30 - flow-typed/npm/react-dom_v17.x.x.js line 30 – 'unstable_batchedUpdates' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L39 - flow-typed/npm/react-dom_v17.x.x.js line 39 – 'unstable_renderSubtreeIntoContainer' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L50 - flow-typed/npm/react-dom_v17.x.x.js line 50 – 'version' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L52 - flow-typed/npm/react-dom_v17.x.x.js line 52 – 'renderToString' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L54 - flow-typed/npm/react-dom_v17.x.x.js line 54 – 'renderToStaticMarkup' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L56 - flow-typed/npm/react-dom_v17.x.x.js line 56 – 'renderToNodeStream' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L58 - flow-typed/npm/react-dom_v17.x.x.js line 58 – 'renderToStaticNodeStream' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L68 - flow-typed/npm/react-dom_v17.x.x.js line 68 – 'Simulate' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L76 - flow-typed/npm/react-dom_v17.x.x.js line 76 – 'renderIntoDocument' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L80 - flow-typed/npm/react-dom_v17.x.x.js line 80 – 'mockComponent' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L85 - flow-typed/npm/react-dom_v17.x.x.js line 85 – 'isElement' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L87 - flow-typed/npm/react-dom_v17.x.x.js line 87 – 'isElementOfType' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L92 - flow-typed/npm/react-dom_v17.x.x.js line 92 – 'isDOMComponent' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L94 - flow-typed/npm/react-dom_v17.x.x.js line 94 – 'isCompositeComponent' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L98 - flow-typed/npm/react-dom_v17.x.x.js line 98 – 'isCompositeComponentWithType' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L103 - flow-typed/npm/react-dom_v17.x.x.js line 103 – 'findAllInRenderedTree' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L108 - flow-typed/npm/react-dom_v17.x.x.js line 108 – 'scryRenderedDOMComponentsWithClass' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L113 - flow-typed/npm/react-dom_v17.x.x.js line 113 – 'findRenderedDOMComponentWithClass' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L118 - flow-typed/npm/react-dom_v17.x.x.js line 118 – 'scryRenderedDOMComponentsWithTag' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L123 - flow-typed/npm/react-dom_v17.x.x.js line 123 – 'findRenderedDOMComponentWithTag' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L128 - flow-typed/npm/react-dom_v17.x.x.js line 128 – 'scryRenderedComponentsWithType' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L133 - flow-typed/npm/react-dom_v17.x.x.js line 133 – 'findRenderedComponentWithType' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-dom_v17.x.x.js#L138 - flow-typed/npm/react-dom_v17.x.x.js line 138 – 'act' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-test-renderer_v16.x.x.js#L49 - flow-typed/npm/react-test-renderer_v16.x.x.js line 49 – Strings must use singlequote. (quotes)

⚠️

flow-typed/npm/react-test-renderer_v16.x.x.js#L62 - flow-typed/npm/react-test-renderer_v16.x.x.js line 62 – 'create' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-test-renderer_v16.x.x.js#L67 - flow-typed/npm/react-test-renderer_v16.x.x.js line 67 – 'act' is defined but never used. (no-unused-vars)

⚠️

flow-typed/npm/react-test-renderer_v16.x.x.js#L70 - flow-typed/npm/react-test-renderer_v16.x.x.js line 70 – Strings must use singlequote. (quotes)

⚠️

flow-typed/npm/yargs_v17.x.x.js#L3 - flow-typed/npm/yargs_v17.x.x.js line 3 – Strings must use singlequote. (quotes)

Generated by 🚫 dangerJS against 6772dce

@analysis-bot
Copy link

analysis-bot commented May 31, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,420 -4
android hermes armeabi-v7a 8,056,626 -5
android hermes x86 9,235,548 -4
android hermes x86_64 9,086,381 +0
android jsc arm64-v8a 9,307,264 -2
android jsc armeabi-v7a 8,496,808 -5
android jsc x86 9,369,283 -1
android jsc x86_64 9,624,204 -1

Base commit: e449706
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46313482

huntie added a commit to huntie/react-native that referenced this pull request Jun 6, 2023
Summary:
Pull Request resolved: facebook#37636

Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root.

- This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages.
- **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included `flow-typed/` directory from the `react-native` package

- **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636).

Reviewed By: hoxyq

Differential Revision: D46313482

fbshipit-source-id: 3d4115b66500a85668f4f5d7c42f236c454c03ae
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46313482

huntie added a commit to huntie/react-native that referenced this pull request Jun 7, 2023
Summary:
Pull Request resolved: facebook#37636

Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root.

- This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages.
- **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included `flow-typed/` directory from the `react-native` package

- **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636).

Reviewed By: hoxyq

Differential Revision: D46313482

fbshipit-source-id: bc6f513e3e17749f6f835bf8e3dc8887d02851db
huntie added a commit to huntie/react-native that referenced this pull request Jun 7, 2023
Summary:
Pull Request resolved: facebook#37636

Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root.

- This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages.
- **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included `flow-typed/` directory from the `react-native` package

- **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636).

Reviewed By: hoxyq

Differential Revision: D46313482

fbshipit-source-id: b3f94420cefac62b0ae9b4acfb97b09cfc296837
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46313482

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46313482

huntie added a commit to huntie/react-native that referenced this pull request Jun 7, 2023
Summary:
Pull Request resolved: facebook#37636

Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root.

- This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages.
- **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included `flow-typed/` directory from the `react-native` package

- **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636).

Reviewed By: hoxyq

Differential Revision: D46313482

fbshipit-source-id: 853a95bdc44e95443964aed28bd7488b63b69b88
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46313482

huntie added a commit to huntie/react-native that referenced this pull request Jun 7, 2023
Summary:
Pull Request resolved: facebook#37636

Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root.

- This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages.
- **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included `flow-typed/` directory from the `react-native` package

- **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636).

Reviewed By: hoxyq

Differential Revision: D46313482

fbshipit-source-id: 9af892b8274d20f750b7f9b13d366c492032f336
Summary:
Pull Request resolved: facebook#37636

Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root.

- This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages.
- **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included `flow-typed/` directory from the `react-native` package

- **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636).

Reviewed By: hoxyq

Differential Revision: D46313482

fbshipit-source-id: ee0f0bb507716c1896a90b2f3f6ca15d9343902e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46313482

facebook-github-bot pushed a commit to facebook/metro that referenced this pull request Jun 7, 2023
Summary:
X-link: facebook/react-native#37636

Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root.

- This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages.
- **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).

Changelog:
[General][Breaking] Remove included `flow-typed/` directory from the `react-native` package

- **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [#37636](facebook/react-native#37636).

Reviewed By: hoxyq

Differential Revision: D46313482

fbshipit-source-id: 3d97d5408e44dd43132664c4933f3ff1075f90a1
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4540668.

adamaveray added a commit to adamaveray/react-native that referenced this pull request Jun 8, 2023
* main: (1824 commits)
  Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750)
  Migrate JSPackagerClientTest to Kotlin (facebook#37747)
  (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746)
  Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745)
  Move flow-typed definitions to repo root (facebook#37636)
  Convert InterpolatorTypeTest to Kotlin (facebook#37724)
  Update documentation of ReactHost.reload method (facebook#37691)
  Reduce visibility of ReactHost.destroy() method (facebook#37693)
  Reduce visibility in React Context (facebook#37695)
  Remove InstanceHandleHelper as unused (facebook#37740)
  Convert CompositeReactPackageTest to Kotlin (facebook#37734)
  Add license header to SetSpanOperation.java
  Convert FakeEventDispatcher to kotlin (facebook#37739)
  Convert FakeRCTEventEmitter to Kotlin (facebook#37733)
  Convert InteropModuleRegistryTest to Kotlin (facebook#37735)
  Bump `autorebase.yml` to `v1.8` (facebook#37584)
  Convert StackTraceHelperTest to Kotlin (facebook#37741)
  Convert BlobModuleTest class to Kotlin (facebook#37719)
  Update prettier to v2.8.8 (facebook#37738)
  Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744)
  ...

# Conflicts:
#	BUCK
#	packages/react-native/React/Views/UIResponder+FirstResponder.h
#	packages/react-native/React/Views/UIResponder+FirstResponder.m
@huntie huntie deleted the export-D46313482 branch August 29, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants