-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move flow-typed definitions to repo root #37636
Conversation
This pull request was exported from Phabricator. Differential Revision: D46313482 |
|
Base commit: e449706 |
This pull request was exported from Phabricator. Differential Revision: D46313482 |
Summary: Pull Request resolved: facebook#37636 Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root. - This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages. - **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs). Changelog: [General][Breaking] Remove included `flow-typed/` directory from the `react-native` package - **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636). Reviewed By: hoxyq Differential Revision: D46313482 fbshipit-source-id: 3d4115b66500a85668f4f5d7c42f236c454c03ae
This pull request was exported from Phabricator. Differential Revision: D46313482 |
Summary: Pull Request resolved: facebook#37636 Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root. - This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages. - **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs). Changelog: [General][Breaking] Remove included `flow-typed/` directory from the `react-native` package - **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636). Reviewed By: hoxyq Differential Revision: D46313482 fbshipit-source-id: bc6f513e3e17749f6f835bf8e3dc8887d02851db
Summary: Pull Request resolved: facebook#37636 Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root. - This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages. - **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs). Changelog: [General][Breaking] Remove included `flow-typed/` directory from the `react-native` package - **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636). Reviewed By: hoxyq Differential Revision: D46313482 fbshipit-source-id: b3f94420cefac62b0ae9b4acfb97b09cfc296837
This pull request was exported from Phabricator. Differential Revision: D46313482 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D46313482 |
Summary: Pull Request resolved: facebook#37636 Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root. - This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages. - **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs). Changelog: [General][Breaking] Remove included `flow-typed/` directory from the `react-native` package - **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636). Reviewed By: hoxyq Differential Revision: D46313482 fbshipit-source-id: 853a95bdc44e95443964aed28bd7488b63b69b88
This pull request was exported from Phabricator. Differential Revision: D46313482 |
Summary: Pull Request resolved: facebook#37636 Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root. - This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages. - **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs). Changelog: [General][Breaking] Remove included `flow-typed/` directory from the `react-native` package - **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636). Reviewed By: hoxyq Differential Revision: D46313482 fbshipit-source-id: 9af892b8274d20f750b7f9b13d366c492032f336
Summary: Pull Request resolved: facebook#37636 Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root. - This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages. - **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs). Changelog: [General][Breaking] Remove included `flow-typed/` directory from the `react-native` package - **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [facebook#37636](facebook#37636). Reviewed By: hoxyq Differential Revision: D46313482 fbshipit-source-id: ee0f0bb507716c1896a90b2f3f6ca15d9343902e
This pull request was exported from Phabricator. Differential Revision: D46313482 |
Summary: X-link: facebook/react-native#37636 Moves `flow-typed/` directory from `packages/react-native/flow-typed/` to the repo root. - This is a more suitable location for `flow-typed` definitions for 3P dependencies to be used across React Native packages. - **Breaking**: We no longer publish these 3P libdefs as part of the `react-native` package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs). Changelog: [General][Breaking] Remove included `flow-typed/` directory from the `react-native` package - **Upgrade instructions**: Projects using Flow should install or replicate third party `flow-typed` definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and [#37636](facebook/react-native#37636). Reviewed By: hoxyq Differential Revision: D46313482 fbshipit-source-id: 3d97d5408e44dd43132664c4933f3ff1075f90a1
This pull request has been merged in 4540668. |
* main: (1824 commits) Convert FallbackJSBundleLoaderTest to Kotlin (facebook#37750) Migrate JSPackagerClientTest to Kotlin (facebook#37747) (refactor): kotlin-ify `ShareModuleTest.java` (facebook#37746) Upgrade `@react-native/codegen-typescript-test`'s Jest dependency to Jest 29 (facebook#37745) Move flow-typed definitions to repo root (facebook#37636) Convert InterpolatorTypeTest to Kotlin (facebook#37724) Update documentation of ReactHost.reload method (facebook#37691) Reduce visibility of ReactHost.destroy() method (facebook#37693) Reduce visibility in React Context (facebook#37695) Remove InstanceHandleHelper as unused (facebook#37740) Convert CompositeReactPackageTest to Kotlin (facebook#37734) Add license header to SetSpanOperation.java Convert FakeEventDispatcher to kotlin (facebook#37739) Convert FakeRCTEventEmitter to Kotlin (facebook#37733) Convert InteropModuleRegistryTest to Kotlin (facebook#37735) Bump `autorebase.yml` to `v1.8` (facebook#37584) Convert StackTraceHelperTest to Kotlin (facebook#37741) Convert BlobModuleTest class to Kotlin (facebook#37719) Update prettier to v2.8.8 (facebook#37738) Introduce BoltsFutureTask class to avoid leaking bolts.Task into ReactHost API (facebook#37744) ... # Conflicts: # BUCK # packages/react-native/React/Views/UIResponder+FirstResponder.h # packages/react-native/React/Views/UIResponder+FirstResponder.m
Summary:
Moves
flow-typed/
directory frompackages/react-native/flow-typed/
to the repo root.flow-typed
definitions for 3P dependencies to be used across React Native packages.react-native
package (assuming that external use of React Native with Flow is extremely rare, and that these projects can manage their own package libdefs).Changelog:
[General][Breaking] Remove included
flow-typed/
directory from thereact-native
packageflow-typed
definitions for React Native dependencies — see https://github.com/facebook/react-native/tree/main/flow-typed and #37636.Differential Revision: D46313482