Parser create getTypeAnnotationName(typeAnnotation) #37580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cipolleschi
requested changes
May 30, 2023
cloudpresser
force-pushed
the
cloudpresser/parser-get-type-annotation-name
branch
from
03b99dc
to
4792837
Compare
Base commit: 0191d16 |
cloudpresser
force-pushed
the
cloudpresser/parser-get-type-annotation-name
branch
from
d76c730
to
b240a29
Compare
|
@cipolleschi I updated this PR with changes suggested here. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -43,7 +43,8 @@ function getPropertyType( | |||
| typeAnnotation: $FlowFixMe, | |||
| parser: Parser, | |||
| ): NamedShape<EventTypeAnnotation> { | |||
| const type = parser.extractTypeFromTypeAnnotation(typeAnnotation); | |||
|
|
|||
There was a problem hiding this comment.
- 🚫 packages/react-native-codegen/src/parsers/flow/components/events.js line 46 – Delete
⏎(prettier/prettier)
| @@ -102,7 +103,9 @@ function extractArrayElementType( | |||
| name: string, | |||
| parser: Parser, | |||
| ): EventTypeAnnotation { | |||
| const type = parser.extractTypeFromTypeAnnotation(typeAnnotation); | |||
|
|
|||
There was a problem hiding this comment.
- 🚫 packages/react-native-codegen/src/parsers/flow/components/events.js line 106 – Replace
⏎··const·type·=·extractTypeFromTypeAnnotation(typeAnnotation,·parser);⏎with··const·type·=·extractTypeFromTypeAnnotation(typeAnnotation,·parser);(prettier/prettier)
| @@ -167,6 +170,16 @@ function prettify(jsonObject: $FlowFixMe): string { | |||
| return JSON.stringify(jsonObject, null, 2); | |||
| } | |||
There was a problem hiding this comment.
- 🚫 packages/react-native-codegen/src/parsers/flow/components/events.js line 171 – Delete
⏎(prettier/prettier)
|
@cloudpresser I'm sorry to ask for this, I have been tried to land this change for a while, but meanwhile the state of the repo has changed. |
cipolleschi
requested changes
Jun 12, 2023
|
/rebase |
|
@cipolleschi merged this pull request in e22d1a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of #34872
Changelog:
[INTERNAL] [ADDED] - getTypeAnnotationName(typeAnnotation) in parser
Test Plan:
yarn jest packages/react-native-codegen> new tests written, as well as coverage from existing tests