pass in bundle url as a dependency of RCTHost #37568
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 6890c07ed0ac97b8c4292c78c5073bee00db40de
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 7f8884ce09c8029b9204105bd4b3effaf358807f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: cd77205b36d17283a10b48478c5662f08638d141
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
Base commit: d4f6cf1 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 1cb19aca8f73ab29b3db0256c55442b4c2e65378
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: caed83b145d105c2b02a42ca6143083ae5899449
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: bb088adf89e0e9d16b563f497f9c7833b647b690
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 77c23349c7ea4821bedcd6a58d761ef50e8158d2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 0f1fe17550ea281bc1f13fb079d7a23fd370c438
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 680df88af94fbbfbff2986d2f85affb25294ef37
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 24882f5bb829d35bc84b1c7158ff448f976b4944
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
Differential Revision: D45937853 fbshipit-source-id: 0df39055ee8f75329376a28f414410548badd3ce
Summary: Pull Request resolved: facebook#37568 Changelog: [Internal] since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of `getBundleURL` from the react host's delegate. Reviewed By: sammy-SC Differential Revision: D45937855 fbshipit-source-id: 86c59a826d2121441f1fea55e857e264bfcbafb6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937855 |
Contributor
|
This pull request has been merged in fb64bbf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
since bundleURL is constant throughout an app session, we should pass it in as a dependency from above. in the next diff, i'll get rid of
getBundleURLfrom the react host's delegate.Reviewed By: sammy-SC
Differential Revision: D45937855