introduce a private API for RCTHost to refresh its bundle url #37567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 8661b5629985cc29479c34d8c80ee11e6b2ef025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 7a15783a57d18780f3a2a0420157639dd22b06bb
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 0df94ed479e6b55a08d29102fd48d045b0733039
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
Base commit: d4f6cf1 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: dde1014bf7f833acfa6045d789c41c86ff84d1d4
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: bb7882ab6f4bad124e2ee2296cbd2314d6b1c9d1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: a62543ec3ce74a9d330470e92eb1a1829e4c3978
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: a85217e88305d365abb1354d848241662e038154
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: c6dcde393e7b9cde7c97e1148857aa73d01d525b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 0eb73ff3f3e4fe0266b62f453fa1f092f4bad120
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 936aa4b5f5d7ce51c0d4711688a5bba40b6bfbf8
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 9b4db146e0f7a6f1421947a8d1c2f78acef07cb0
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 3fda1791e254bd4866710b1eeaab29b8d6454d6a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 430904ea7de4be5d9a8dd0ca3068cf0a3df5dc21
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 5b487c7e0861bbe2a46312d27ce96dc8c1829905
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
May 25, 2023
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 98c71e069ee2eb6127810da55886d479e45593c6
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
Differential Revision: D45937853 fbshipit-source-id: 9a908a4e83b10c0633ed97ed76e3781f11e5467f
Differential Revision: D45937855 fbshipit-source-id: 3c83307dc157e82f2de3b7c0f08c191e0ece0603
…ok#37567) Summary: Pull Request resolved: facebook#37567 Changelog: [Internal] in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session. Reviewed By: cipolleschi Differential Revision: D45937856 fbshipit-source-id: 088ac019ee61baffae1f59a0b91eb903da63531e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45937856 |
Contributor
|
This pull request has been merged in 992c45c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
in the situation where we want to refresh the bundle url due to developer mode, we add a private API that allows the host to refresh its bundle URL if needed. this private API will be called on cmd + R, which is the only case that supports the changing bundle URL in the middle of the app session.
Reviewed By: cipolleschi
Differential Revision: D45937856