Refactor to npm-utils #37555
Closed
Refactor to npm-utils #37555
+114
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46131120 |
Base commit: be8af22 |
Summary: Pull Request resolved: facebook#37555 Changelog: [Internal] Refactor some npm commands and centralize in npm-utils. For now, centralize `getPackageVersionStrByTag` and `publishPackage` and update: 1. `publish-npm` to use utilities. This is how we publish `react-native` for commitlies, releases, and nightlies 2. Update `find-and-publish-all-bumped-packages.js` where we publish our monorepo dependencies Reviewed By: cortinico, hoxyq Differential Revision: D46131120 fbshipit-source-id: 7dd8afbb615d28576d73ea1546c56a30c708532e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46131120 |
lunaleaps
force-pushed
the
export-D46131120
branch
from
510a2bc to
7feabda
Compare
Contributor
|
This pull request has been merged in 7819fef. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal] Refactor some npm commands and centralize in npm-utils.
For now, centralize
getPackageVersionStrByTagandpublishPackageand update:publish-npmto use utilities. This is how we publishreact-nativefor commitlies, releases, and nightliesfind-and-publish-all-bumped-packages.jswhere we publish our monorepo dependenciesReviewed By: cortinico, hoxyq
Differential Revision: D46131120