[Codegen 108]: add handleGenericTypeAnnotation in parser-commons #37525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tarunrajput
commented
May 22, 2023
Contributor
Author
|
/rebase |
github-actions
bot
force-pushed
the
add-handleGenericTypeAnnotation-fn
branch
from
f23889a to
d95cd99
Compare
Base commit: b6b247b |
cipolleschi
requested changes
May 24, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Amazing work! I think we can improve it even a little further, I added some extra comments in the PR
tarunrajput
force-pushed
the
add-handleGenericTypeAnnotation-fn
branch
from
d95cd99 to
5de24f4
Compare
Contributor
Author
|
@cipolleschi , Thank you for the review! I have updated the pull request to address all the points. |
tarunrajput
force-pushed
the
add-handleGenericTypeAnnotation-fn
branch
from
5de24f4 to
d9f4f0f
Compare
cipolleschi
approved these changes
May 29, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
thanks for updating the code! 🙏
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tarunrajput
force-pushed
the
add-handleGenericTypeAnnotation-fn
branch
from
d9f4f0f to
84bdffb
Compare
Contributor
|
@cipolleschi merged this pull request in 8ffaede. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Part of #34872
Move the switch construct from parsers/typescript/utils.js and parsers/flow/utils.js to the parsers-commons.js file, in a handleGenericTypeAnnotation function. Use that function in place of the switch.
Changelog:
[Internal][Added]: Added handleGenericTypeAnnotation in parsers-commons
Test Plan:
yarn test