Skip to content

Conversation

@foestauf
Copy link
Contributor

Summary:

part of #34872

Create a function emitFloatProp(name: string, optional: boolean) in parser-primitives.js. Factor out the code from Flow and TypeScript into that function. Use that function in the original call site.

Changelog:

[INTERNAL] [ADDED] - emitFloatProp in parser primitves

Test Plan:

yarn jest packages/react-native-codegen

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,732,656 -330
android hermes armeabi-v7a 8,043,839 -330
android hermes x86 9,222,768 -316
android hermes x86_64 9,074,741 -320
android jsc arm64-v8a 9,297,413 -470
android jsc armeabi-v7a 8,486,154 -483
android jsc x86 9,358,579 -477
android jsc x86_64 9,614,668 -482

Base commit: f8a1f62
Branch: main

@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label May 22, 2023
@Pranav-yadav
Copy link
Contributor

Hi @foestauf, 👋

Congratulations 🎉 on your "First Pull Request" to React Native! 🥳

Thank you, 🙏 for taking the time to contribute to this project and share your ideas.

Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be merged if it also passes all internal tests. 🥳

P.S.: In the meantime, you should go through below checklist: (click to expand)
  1. Make sure you have signed the CLA 📃🙂,
  2. There are no typos 😄,
  3. All tests 🧪 are passing. i.e. The CI checks should be green 🟢, and
  4. You have added necessary tests for your code, if it's a refactor or a new functionality. 🧪

Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs

@foestauf foestauf marked this pull request as ready for review May 22, 2023 13:20
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @foestauf! Happy to see your first PR!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

/rebase

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 1a1e399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tech: Codegen Related to react-native-codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants