Change how we set cmake policy (#1288) #37349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45724864 |
Base commit: 066f0b7 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 15, 2023
Summary: X-link: facebook/react-native#37349 Pull Request resolved: facebook#1288 Fixes facebook#1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 21c4c6962b0882c5f90746cf343c718e287cc444
NickGerleman
force-pushed
the
export-D45724864
branch
from
7461a79 to
7f7e458
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 15, 2023
Summary: Pull Request resolved: facebook#37349 X-link: facebook/yoga#1288 Fixes facebook/yoga#1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 34385ddf8506b033b353292a1fbeb77a7117f128
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45724864 |
Summary: Pull Request resolved: facebook#37349 X-link: facebook/yoga#1288 Fixes facebook/yoga#1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 46bc309a128470d1fa5d9c69329bba1bbd3cf51a
NickGerleman
force-pushed
the
export-D45724864
branch
from
7f7e458 to
b2b551e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45724864 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
May 15, 2023
Summary: X-link: facebook/react-native#37349 Pull Request resolved: facebook#1288 Fixes facebook#1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 95588cd8a4e3ca426e723f0aaa1d0114b18ac4c3
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
May 15, 2023
Summary: X-link: facebook/react-native#37349 X-link: facebook/yoga#1288 Fixes facebook/yoga#1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 120cc2015a043605e7c07ef0459667643a4284b7
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
May 15, 2023
Summary: X-link: facebook/react-native#37349 Pull Request resolved: #1288 Fixes #1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 120cc2015a043605e7c07ef0459667643a4284b7
Contributor
|
This pull request has been merged in 2b932c3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1288
Fixes facebook/yoga#1283
New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in
cmake_minimum_required.Setting a policy to true (to opt into new behavior where
cmake_minimum_requiredis lower than the current version) seems actually just error out on the old versions.Googling around, apparently the way I should be doing this is to specify
<policy_max>as part ofcmake_minimum_required. https://gitlab.kitware.com/cmake/cmake/-/issues/20392This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum.
Differential Revision: D45724864