Fix podspec setup for 3rd parties when using dynamic linking #37275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
Base commit: e540d05 |
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 5, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: D45523646 fbshipit-source-id: af51f48d5673a12e6e201fcf308f930741a86f96
cipolleschi
force-pushed
the
export-D45523646
branch
from
05d4a04
to
5c3a5e0
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 5, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: D45523646 fbshipit-source-id: c0cc261454663b2a54f02cd85839344131028fd5
cipolleschi
force-pushed
the
export-D45523646
branch
from
5c3a5e0
to
03aba2b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
force-pushed
the
export-D45523646
branch
from
03aba2b
to
7ee5968
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: D45523646 fbshipit-source-id: 10649a4208eaad43560739b15c77de1ed8e111bd
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: af298227c7fdd57b9e276ba7b6e6499151a49250
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: 4749aaeaf4570aec3608f11b4aa95e1248671cc0
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: D45523646 fbshipit-source-id: 3252bdd9cff9943c8beaf9b4d9f92dfe540e52e1
cipolleschi
force-pushed
the
export-D45523646
branch
from
7ee5968
to
314fc6b
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: 93ca83e3edb95b16aba82e145014cb6b6b91f759
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: b193577203ad59adfe7cab822eba0e2aba18bed1
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: 5829c042257d2083c90996446822b49d062228b7
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: 7f6b2f50edd10a8d39c7c682741c3cc6bb737ddd
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: 090a422df147d485b041aaafa173349988e56cf6
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 6, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: D45523646 fbshipit-source-id: 13e61889b985a8ae6d903815f132ca47d50abb6c
cipolleschi
force-pushed
the
export-D45523646
branch
from
314fc6b
to
63b462d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Reviewed By: NickGerleman Differential Revision: D45523646 fbshipit-source-id: d2dd84c173d46267acfaf14f5411ad93074d5462
cipolleschi
force-pushed
the
export-D45523646
branch
from
63b462d
to
87e6111
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: b4d48824d9742500b1242f6e3f50c6f0ccda00cc
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: 482ed891b5dc0f600f20669c673ab047f4e2b0cc
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
May 9, 2023
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Differential Revision: https://internalfb.com/D45523646 fbshipit-source-id: 425728d13de9f8a63f0e2860474c83a840bfb364
…c image component and ImageManager (facebook#37276) Summary: Pull Request resolved: facebook#37276 When enabling dynamic linking, we had a circulr dependency between Fabric and the Image Manager. Specifically, Image Manager depends on Fabric, but the Image component, in Fabric, is using some implementation specific files from the Image Manager that surface only when enabling the dynamic linking. Xcode fails to find those symbols unless the dependencies are explicitly added to the podspec. This change is technically breaking, but we tried to minimize the breakage by adding the new pod in all the required search paths. ## Changelog [iOS][Breaking] - Add React-FabricImage pod. Differential Revision: https://internalfb.com/D45517278 fbshipit-source-id: 89c991bed7c170c6bb2f7f6e8b19ec64847f5454
…k#37275) Summary: Pull Request resolved: facebook#37275 When enabling `USE_FRAMEWORKS=dynamic`, we need to explicitly defines all the dependencies used by the pods. This change add those missing dependencies. ## Changelog: [iOS][Added] - Add explicit dependencies for 3rd parties libraries Reviewed By: NickGerleman Differential Revision: D45523646 fbshipit-source-id: f078e81c6bded0fcbdee34ab53fd1a8e55fb7e28
cipolleschi
force-pushed
the
export-D45523646
branch
from
87e6111
to
aa3118f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45523646 |
|
This pull request has been merged in c027f0a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When enabling
USE_FRAMEWORKS=dynamic, we need to explicitly defines all the dependencies used by the pods.This change add those missing dependencies.
Changelog:
[iOS][Added] - Add explicit dependencies for 3rd parties libraries
Differential Revision: D45523646