Add JSI<->C++ bridging conversion for folly::dynamic #37237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
Base commit: a89b572 |
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
genkikondo
force-pushed
the
export-D45544843
branch
from
cdfa044
to
630e809
Compare
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
May 4, 2023
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Differential Revision: D45544843 fbshipit-source-id: 7ae55334b013a4718cfe8342f75cbab72bce8ef8
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
May 4, 2023
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Differential Revision: D45544843 fbshipit-source-id: a0619f8274cf589526b29ad065443c6983200cda
genkikondo
force-pushed
the
export-D45544843
branch
from
630e809
to
07b36a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
May 4, 2023
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Reviewed By: javache Differential Revision: D45544843 fbshipit-source-id: 8c905a03bb45fd786262f2686846bd097fdf5bc2
genkikondo
force-pushed
the
export-D45544843
branch
from
07b36a6
to
d86eb46
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
May 4, 2023
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Reviewed By: javache Differential Revision: D45544843 fbshipit-source-id: 9a809faa4563d8041e9639069c1b8e79ef37d990
genkikondo
force-pushed
the
export-D45544843
branch
from
d86eb46
to
579f4e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
May 4, 2023
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Reviewed By: javache Differential Revision: D45544843 fbshipit-source-id: 0dfa84aac299fa31a2898fc13aae770d64f7c057
genkikondo
force-pushed
the
export-D45544843
branch
from
579f4e7
to
776cb84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
genkikondo
added a commit
to genkikondo/react-native
that referenced
this pull request
May 4, 2023
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Reviewed By: javache Differential Revision: D45544843 fbshipit-source-id: 210e06a682cfef15499f04e520c953f6daac2aa5
genkikondo
force-pushed
the
export-D45544843
branch
from
776cb84
to
7fbfcca
Compare
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Reviewed By: javache Differential Revision: D45544843 fbshipit-source-id: 2a77a9121b71220fea2ebcd3c3a773054bf97c65
genkikondo
force-pushed
the
export-D45544843
branch
from
7fbfcca
to
713d021
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45544843 |
|
This pull request has been merged in d3fbcbb. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37237 Enables bridging conversions to/from jsi::Value and folly::dynamic. Changelog: [Internal] - Add JSI<->C++ bridging conversion for folly::dynamic Reviewed By: javache Differential Revision: D45544843 fbshipit-source-id: 89e773705a11eb3c5818cd081ef8c63436dc3340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables bridging conversions to/from jsi::Value and folly::dynamic.
Changelog:
[Internal] - Add JSI<->C++ bridging conversion for folly::dynamic
Differential Revision: D45544843