Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Array parsing in events #37142

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This diff introduce support to parse arrays in events.

We support parsing Arrays of:

  • Boolean
  • Double
  • Float
  • Int32
  • String Enums
  • String
  • Objects
  • Arrays

Changelog:

[General][Added] - Add generic support for Arrays in Events parsing

Differential Revision: D45268779

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 28, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45268779

@analysis-bot
Copy link

analysis-bot commented Apr 28, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,629,445 +3
android hermes armeabi-v7a 7,941,034 +3
android hermes x86 9,115,988 +3
android hermes x86_64 8,970,294 +1
android jsc arm64-v8a 9,193,602 +4
android jsc armeabi-v7a 8,382,657 +5
android jsc x86 9,251,492 -1
android jsc x86_64 9,509,441 +1

Base commit: 1cd0f57
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45268779

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 2, 2023
Summary:
Pull Request resolved: facebook#37142

This diff introduce support to parse arrays in events.

We support parsing Arrays of:
- Boolean
- Double
- Float
- Int32
- String Enums
- String
- Objects
- Arrays

## Changelog:
[General][Added] - Add generic support for Arrays in Events parsing

Reviewed By: dmytrorykun, RSNara

Differential Revision: D45268779

fbshipit-source-id: cf3a2c7f18aecda0731dac31e9eca7e92b3281d6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45268779

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 2, 2023
Summary:
Pull Request resolved: facebook#37142

This diff introduce support to parse arrays in events.

We support parsing Arrays of:
- Boolean
- Double
- Float
- Int32
- String Enums
- String
- Objects
- Arrays

## Changelog:
[General][Added] - Add generic support for Arrays in Events parsing

Reviewed By: dmytrorykun, RSNara

Differential Revision: D45268779

fbshipit-source-id: bc55e5d2943f23a330830f1e1a9df8516415ba93
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 3, 2023
Summary:
Pull Request resolved: facebook#37142

This diff introduce support to parse arrays in events.

We support parsing Arrays of:
- Boolean
- Double
- Float
- Int32
- String Enums
- String
- Objects
- Arrays

## Changelog:
[General][Added] - Add generic support for Arrays in Events parsing

Reviewed By: dmytrorykun, RSNara

Differential Revision: D45268779

fbshipit-source-id: 36b8c565321619f6774c299d4d3ff0a6a9e93d2b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45268779

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 4, 2023
Summary:
Pull Request resolved: facebook#37142

This diff introduce support to parse arrays in events.

We support parsing Arrays of:
- Boolean
- Double
- Float
- Int32
- String Enums
- String
- Objects
- Arrays

## Changelog:
[General][Added] - Add generic support for Arrays in Events parsing

Reviewed By: dmytrorykun, RSNara

Differential Revision: D45268779

fbshipit-source-id: 4ccb4d955a970cb9f9c016067085267ec2f0a389
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45268779

Summary:
Pull Request resolved: facebook#37142

This diff introduce support to parse arrays in events.

We support parsing Arrays of:
- Boolean
- Double
- Float
- Int32
- String Enums
- String
- Objects
- Arrays

## Changelog:
[General][Added] - Add generic support for Arrays in Events parsing

Reviewed By: dmytrorykun, RSNara

Differential Revision: D45268779

fbshipit-source-id: 301bcb23599e2fd86805d3bedb9ba2a16da8653c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45268779

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 4, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6168701.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#37142

This diff introduce support to parse arrays in events.

We support parsing Arrays of:
- Boolean
- Double
- Float
- Int32
- String Enums
- String
- Objects
- Arrays

## Changelog:
[General][Added] - Add generic support for Arrays in Events parsing

Reviewed By: dmytrorykun, RSNara

Differential Revision: D45268779

fbshipit-source-id: 0c6eae65eb2b41ebf7b47a4cc3e0f0e5fa20d871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants