Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout #37139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45390819 |
Base commit: 30da587 |
…layout (facebook#37139) Summary: Pull Request resolved: facebook#37139 This dependency is unnecessary. React Native already exposes a `api` dependency on `androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it. This is just another line in the template we can effectively remove. Changelog: [Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout Reviewed By: cipolleschi Differential Revision: D45390819 fbshipit-source-id: 883571deb88885bedd8e748415d77e9dd796e183
cortinico
force-pushed
the
export-D45390819
branch
from
98cba2d
to
80cab21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45390819 |
|
This pull request has been merged in 179d5ab. |
kelset
pushed a commit
that referenced
this pull request
May 3, 2023
…layout (#37139) Summary: Pull Request resolved: #37139 This dependency is unnecessary. React Native already exposes a `api` dependency on `androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it. This is just another line in the template we can effectively remove. Changelog: [Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout Reviewed By: cipolleschi Differential Revision: D45390819 fbshipit-source-id: cce34c6a09100d36ee5eb003bb30323f64f0bb9c
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…layout (facebook#37139) Summary: Pull Request resolved: facebook#37139 This dependency is unnecessary. React Native already exposes a `api` dependency on `androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it. This is just another line in the template we can effectively remove. Changelog: [Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout Reviewed By: cipolleschi Differential Revision: D45390819 fbshipit-source-id: cce34c6a09100d36ee5eb003bb30323f64f0bb9c
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
…layout (#37139) Summary: Pull Request resolved: facebook/react-native#37139 This dependency is unnecessary. React Native already exposes a `api` dependency on `androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it. This is just another line in the template we can effectively remove. Changelog: [Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout Reviewed By: cipolleschi Differential Revision: D45390819 fbshipit-source-id: cce34c6a09100d36ee5eb003bb30323f64f0bb9c Original: facebook/react-native@179d5ab
This was referenced Feb 28, 2024
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
…layout (#37139) Summary: Pull Request resolved: facebook/react-native#37139 This dependency is unnecessary. React Native already exposes a `api` dependency on `androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it. This is just another line in the template we can effectively remove. Changelog: [Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout Reviewed By: cipolleschi Differential Revision: D45390819 fbshipit-source-id: cce34c6a09100d36ee5eb003bb30323f64f0bb9c Original-Commit: facebook/react-native@179d5ab
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
…layout (#37139) Summary: Pull Request resolved: facebook/react-native#37139 This dependency is unnecessary. React Native already exposes a `api` dependency on `androidx.swiperefreshlayout:swiperefreshlayout` so every consumer will also get it. This is just another line in the template we can effectively remove. Changelog: [Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout Reviewed By: cipolleschi Differential Revision: D45390819 fbshipit-source-id: cce34c6a09100d36ee5eb003bb30323f64f0bb9c Original-Commit: facebook/react-native@179d5ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This dependency is unnecessary. React Native already exposes a
apidependency onandroidx.swiperefreshlayout:swiperefreshlayoutso every consumer will also get it.This is just another line in the template we can effectively remove.
Changelog:
[Android] [Changed] - Do not explicitely depend on androidx.swiperefreshlayout:swiperefreshlayout
Differential Revision: D45390819