Deprecate YGConfigSetUseLegacyStretchBehaviour (#1265) #37117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Differential Revision: D45337198 fbshipit-source-id: 50cb6a562c65cead4dd6197a6545a7a127e1a688
Base commit: bd30131 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: eb7453e3b5b50c8f774204d695d08aadd2e8a075
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 2ad47ecd8b9dc6dde2a9f4772e30815e5ef7508a
NickGerleman
force-pushed
the
export-D45337198
branch
from
40c5b8d
to
57e9f00
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: ac6d251e43475444e68fec91e14dd6aea46e9e0e
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 19715d6826ac59f04aacb4cf0fa72fb287e38573
NickGerleman
force-pushed
the
export-D45337198
branch
from
57e9f00
to
3bec47e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: e39b4bd115c204c2b811f26a1a49a412d84256b1
NickGerleman
force-pushed
the
export-D45337198
branch
from
3bec47e
to
188aa4a
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: db3ed9bdb1bbd8890be917a39df66c4f59373c6b
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: a1e119be7ea592bc504c75c55195fd14e24ea141
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 4c9e5ada17163cef4b9736f3566ffce63e340e4e
NickGerleman
force-pushed
the
export-D45337198
branch
from
188aa4a
to
244f80f
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: ad199acd957dc378dc77832f34cbbd42ef35c0b8
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 6b3b0883352ce80119b9933252491fb3eaf5e5bd
NickGerleman
force-pushed
the
export-D45337198
branch
from
244f80f
to
dc05a73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 28, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 703cf9223a81442a1e0c8b9f246badc65a64044e
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 28, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: fcd51ba2f546c4051dd95c1e8a00024386dd654c
NickGerleman
force-pushed
the
export-D45337198
branch
from
dc05a73
to
ca63779
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 29, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 8df4f73ee8bb0b7a58874f0e6b706d2e80220ba8
NickGerleman
force-pushed
the
export-D45337198
branch
from
4ccb317
to
955e6a8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 29, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 7e2ea9b144dec5a3dff415ed479dee5df71b7fbe
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 29, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 89b1636aaa6e4fdc33767e6a3a4bb4b6826a1467
NickGerleman
force-pushed
the
export-D45337198
branch
from
955e6a8
to
af3bc23
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 29, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 4ff2a9aa080af792c026216073cdcfb1d41c1937
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 29, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 12aac7db3550bd644d5deabe65d9693ab8a00e77
NickGerleman
force-pushed
the
export-D45337198
branch
from
af3bc23
to
6eb394a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: aacf3ae6984859a75cf86ff72f60d27cf03e2a8c
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 30, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 186e7e90232b254ffb0bd347309c3f29efd5ef07
NickGerleman
force-pushed
the
export-D45337198
branch
from
6eb394a
to
89cc039
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 3faa7dbdfa5197b69070d938b26b1cef0602ae03
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 30, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 33017a407bed0251196fa9adf93f4d31fcfe10be
NickGerleman
force-pushed
the
export-D45337198
branch
from
89cc039
to
71622a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: facebook#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 3339923e998a88fe0f7f12b875896706b2f40a1a
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: fd1b817bdcaefff52d1fc5e9bfa4b5856e9c4d0c
NickGerleman
force-pushed
the
export-D45337198
branch
from
71622a0
to
44e8290
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45337198 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 7f069623e38834171f5702382bbf47c37a556a22
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Apr 30, 2023
Summary: X-link: facebook/react-native#37117 Pull Request resolved: #1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 7f069623e38834171f5702382bbf47c37a556a22
|
This pull request has been merged in 7f300cd. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37117 X-link: facebook/yoga#1265 This deprecates `YGConfigSetUseLegacyStretchBehaviour` and `YGConfigGetUseLegacyStretchBehaviour`and points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with `-Werror`, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface). Reviewed By: rshest Differential Revision: D45337198 fbshipit-source-id: 7f069623e38834171f5702382bbf47c37a556a22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1265
This deprecates
YGConfigSetUseLegacyStretchBehaviourandYGConfigGetUseLegacyStretchBehaviourand points users to errata APIs instead. Using the C API will fire deprecation warnings, which should create errors in builds with-Werror, though they can be ignored if truly needed (like we do with the language bindings which need to expose their own deprecated interface).Differential Revision: D45337198