Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use C++17 namespace format everywhere #36987

Closed

Conversation

christophpurrer
Copy link
Contributor

Summary: Changelog: [Internal]

Differential Revision: D45130727

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45130727

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45130727

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Apr 20, 2023
Summary:
Pull Request resolved: facebook#36987

Changelog: [Internal]

Differential Revision: D45130727

fbshipit-source-id: 9ed1a63c7bd646c086eca069e50228f24b3d8f87
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Apr 20, 2023
Summary:
Pull Request resolved: facebook#36987

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D45130727

fbshipit-source-id: 89f4a5b17dd68d83b40853c72f5f8e4f4bec5caa
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45130727

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Apr 20, 2023
Summary:
Pull Request resolved: facebook#36987

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D45130727

fbshipit-source-id: 4cb79ba7d3b59ddb7d0f7d9053abcc6782db220e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45130727

Summary:
Pull Request resolved: facebook#36987

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D45130727

fbshipit-source-id: dfbd6397c73b1b43aad6fe3cb18022a50f005e0c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45130727

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,620,441 -58
android hermes armeabi-v7a 7,933,503 -10
android hermes x86 9,106,940 +2
android hermes x86_64 8,961,814 -18
android jsc arm64-v8a 9,186,786 -54
android jsc armeabi-v7a 8,377,486 -9
android jsc x86 9,244,888 +5
android jsc x86_64 9,503,447 -21

Base commit: eab32f1
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 65f5cd7.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 20, 2023
jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36987

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D45130727

fbshipit-source-id: 66f9fbd2a3a5f4d637b59bee77d085a35117d69d
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36987

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D45130727

fbshipit-source-id: 66f9fbd2a3a5f4d637b59bee77d085a35117d69d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants