Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support events with mixed payloads in codegen #36942

Closed
wants to merge 1 commit into from

Conversation

genkikondo
Copy link
Contributor

Summary:
Changelog:
[Changed][General] - Support mixed props for events in codegen

Differential Revision: D44580879

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44580879

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against 7345494

@analysis-bot
Copy link

analysis-bot commented Apr 18, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,620,291 +20
android hermes armeabi-v7a 7,932,972 +18
android hermes x86 9,106,249 -16
android hermes x86_64 8,961,070 -14
android jsc arm64-v8a 9,186,890 +16
android jsc armeabi-v7a 8,377,172 +8
android jsc x86 9,244,452 -4
android jsc x86_64 9,502,961 -10

Base commit: 645b643
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44580879

genkikondo added a commit to genkikondo/react-native that referenced this pull request Apr 18, 2023
Summary:
Pull Request resolved: facebook#36942

Changelog:
[General][Changed] - Support mixed props for events in codegen

Reviewed By: javache

Differential Revision: D44580879

fbshipit-source-id: 1446981f38130243279b019f94686eb7cd46c91d
Summary:
Pull Request resolved: facebook#36942

Changelog:
[General][Changed] - Support mixed props for events in codegen

Reviewed By: javache

Differential Revision: D44580879

fbshipit-source-id: 7e50bee327ae0e4cfe862470cca9e35cea70b772
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44580879

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b68f53d.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36942

Changelog:
[General][Changed] - Support mixed props for events in codegen

Reviewed By: javache

Differential Revision: D44580879

fbshipit-source-id: 52f3b12795af767c038e2db7a4faf46cf2906b95
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36942

Changelog:
[General][Changed] - Support mixed props for events in codegen

Reviewed By: javache

Differential Revision: D44580879

fbshipit-source-id: 52f3b12795af767c038e2db7a4faf46cf2906b95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants