chore: Extract logic to compute codegen TS extendsProps and props in getProps function #36889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
gabrieldonadel
force-pushed
the
chore/codegen-get-props
branch
from
df56c20 to
b8a6e10
Compare
Base commit: 9f24df0 |
gabrieldonadel
force-pushed
the
chore/codegen-get-props
branch
from
b8a6e10 to
75e006e
Compare
…getProps function
gabrieldonadel
force-pushed
the
chore/codegen-get-props
branch
from
75e006e to
0a6e78c
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in e962d43. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…getProps function (facebook#36889) Summary: [Codegen 103] This PR extracts the logic to compute the `extendsProps` and `props` properties in TypeScript Codegen in a `getProps()` function as requested on facebook#34872 ## Changelog: [Internal] [Added] - Extract logic to compute codegen TS `extendsProps` and `props` properties in a single `getProps` function Pull Request resolved: facebook#36889 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green Reviewed By: rshest Differential Revision: D44952664 Pulled By: cipolleschi fbshipit-source-id: fd51f0b8767efbb0071b6391e0852c19b5a984c6
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…getProps function (facebook#36889) Summary: [Codegen 103] This PR extracts the logic to compute the `extendsProps` and `props` properties in TypeScript Codegen in a `getProps()` function as requested on facebook#34872 ## Changelog: [Internal] [Added] - Extract logic to compute codegen TS `extendsProps` and `props` properties in a single `getProps` function Pull Request resolved: facebook#36889 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green Reviewed By: rshest Differential Revision: D44952664 Pulled By: cipolleschi fbshipit-source-id: fd51f0b8767efbb0071b6391e0852c19b5a984c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Codegen 103] This PR extracts the logic to compute the
extendsPropsandpropsproperties in TypeScript Codegen in agetProps()function as requested on #34872Changelog:
[Internal] [Added] - Extract logic to compute codegen TS
extendsPropsandpropsproperties in a singlegetPropsfunctionTest Plan:
Run
yarn jest react-native-codegenand ensure CI is green