Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce visibility of FabricSoLoader #36749

Closed
wants to merge 1 commit into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Mar 31, 2023

Summary:
Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 31, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44153451

@analysis-bot
Copy link

analysis-bot commented Mar 31, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,570,263 +17
android hermes armeabi-v7a 7,884,649 +18
android hermes x86 9,052,180 +15
android hermes x86_64 8,907,207 +3
android jsc arm64-v8a 9,168,062 +54
android jsc armeabi-v7a 8,358,464 +48
android jsc x86 9,224,729 +45
android jsc x86_64 9,482,568 +52

Base commit: 4890d50
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44153451

mdvacca added a commit to mdvacca/react-native that referenced this pull request Mar 31, 2023
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: 1848243c9cdc969f9a5b384f96dfbe3b963c9d3d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44153451

mdvacca added a commit to mdvacca/react-native that referenced this pull request Mar 31, 2023
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: 72d424f35cde052141821dff273112ec4b36004a
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: e5cc6728d609a27728478943c7484a769676afc0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44153451

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fb92021.

mdvacca added a commit to mdvacca/react-native that referenced this pull request Apr 4, 2023
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: ea5583ea9599ae323912a91fb946ea11452e5444
mdvacca added a commit to mdvacca/react-native that referenced this pull request Apr 4, 2023
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: f6299ce8b7dc87c3692c77c41b0ec66b8b141c06
mdvacca added a commit to mdvacca/react-native that referenced this pull request Apr 4, 2023
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: e487d89f75bdc8d85522d2ca2aec0c14835b8dde
jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: 942c80da3987d3639b055804c24fc34543a99907
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36749

Reduce visibility of FabricSoLoader

This is a breaking change, but nobody should be using this class

Changelog: [internal] internal

Reviewed By: javache, cortinico

Differential Revision: D44153451

fbshipit-source-id: 942c80da3987d3639b055804c24fc34543a99907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants