Change PerformanceApiExample to use ModulePathing #36478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 58d88ec |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Recent integration from Windows brought in PerformanceApiExample that uses relative pathing to access react-native library. This causes us to have to override the file since our file structure is different. microsoft/react-native-windows#11373 This PR changes the example to use module pathing instead. ## Changelog [GENERAL] [CHANGED] - Change PerformanceApiExample to use ModulePathing Pull Request resolved: facebook#36478 Test Plan: Tested and passed Windows tests Reviewed By: rshest Differential Revision: D44089501 Pulled By: javache fbshipit-source-id: 99993a4f81556b4fef7c5d15af26b20df960ebf9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent integration from Windows brought in PerformanceApiExample that uses relative pathing to access react-native library. This causes us to have to override the file since our file structure is different. microsoft/react-native-windows#11373
This PR changes the example to use module pathing instead.
Changelog
[GENERAL] [CHANGED] - Change PerformanceApiExample to use ModulePathing
Test Plan
Tested and passed Windows tests