[Codegen 95]: Merge defaultExports.forEach(statement => ... (Flow, TS) to findNativeComponentType fn in parser-commons.js
#36466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 681d7f8 |
cipolleschi
requested changes
Mar 15, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Great work here! I left a comment for something that you may have missed.
A part from that, it looks good to me! ;)
Contributor
|
(also, it needs a rebase and conflict resolution) ;) |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Pranav-yadav
force-pushed
the
codegen95defaultExports
branch
2 times, most recently
from
1c40c47 to
29c85f1
Compare
Contributor
Author
|
@cipolleschi rebased & resolved conflicts but, dk why ci keeps failing these days 🤔 (especially on my PRs 🫠 jk) Edit: the same thing is happening on my another PR |
Contributor
|
/rebase |
Contributor
Not sure why this is the case. Trying to rebase to see if this solves the issue. One of the failure was a transient network issue |
… fn's Add below fn's to `parser` (Flow & TS): - `getTypeArgumentParamsFromDeclaration` : Given a declaration, it returns the typeArgumentParams of the declaration. - `getNativeComponentType` : Given a typeArgumentParams and funcArgumentParams it returns a native component type.
Add below fn which unifies the `defaultExports.forEach(statement => ..` behaviors between Flow & TS: - `findNativeComponentType` : This function is used to find the type of a native component provided the default exports statement from generated AST.
…tiveComponentType` fn in `parser-commons.js`
github-actions
bot
force-pushed
the
codegen95defaultExports
branch
from
29c85f1 to
d5089b9
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in c0a46c6. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…tiveComponentType` fn in `parser-commons.js` (facebook#36466) Summary: >[Codegen 95] Extract the `defaultExports.forEach(statement =>` (Flow, TS) function in `parser-commons`, so that it accept a Parser parameter to unify the behaviors between flow and typescript. The Parser object needs to be enriched with all the methods to extract the required information from the Node, if they are not there yet. ### Changes - merged TS & Flow parsers' logic for `defaultExports.forEach(statement =>` of `/components/index.js:findComponentConfig()` into; - `findNativeComponentType` fn to `parsers-commons.js` - add `getTypeArgumentParamsFromDeclaration` & `getNativeComponentType` fn's - add **_tests_** for getTypeArgumentParamsFromDeclaration & `getNativeComponentType` fn's ## Changelog [INTERNAL] [CHANGED] - Merge `defaultExports.forEach(statement => ...` (Flow, TS) to `findNativeComponentType` fn in `parser-commons.js` Pull Request resolved: facebook#36466 Test Plan: - `yarn lint && yarn run flow && yarn jest react-native` ⇒ � Reviewed By: rshest Differential Revision: D44088862 Pulled By: cipolleschi fbshipit-source-id: 91bf0edcd53b2e054160af34d7c128355c178b26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
defaultExports.forEach(statement =>of/components/index.js:findComponentConfig()into;findNativeComponentTypefn toparsers-commons.jsgetTypeArgumentParamsFromDeclaration&getNativeComponentTypefn'sgetNativeComponentTypefn'sChangelog
[INTERNAL] [CHANGED] - Merge
defaultExports.forEach(statement => ...(Flow, TS) tofindNativeComponentTypefn inparser-commons.jsTest Plan
yarn lint && yarn run flow && yarn jest react-native⇒ 🟢