Skip to content

[Codegen 89 & 90] Remove hardcoded language from modules/index.js #36435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+3 −13
Closed

[Codegen 89 & 90] Remove hardcoded language from modules/index.js #36435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8087a30
refactor: remove useless language param in typeEnumResolution
MaeIg Mar 10, 2023
8b56bfa
refactor: remove hardcoded language in flow/modules/index
MaeIg Mar 10, 2023
09dde4b
refactor: remove hardcoded language in typescript/modules/index
MaeIg Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/react-native-codegen/src/parsers/__tests__/parsers-primitives-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,6 @@ describe('typeEnumResolution', () => {
{successful: true, type: 'enum', name: 'Foo'},
true /* nullable */,
'SomeModule' /* name */,
'Flow',
enumMap,
parser,
);
Expand Down Expand Up @@ -402,7 +401,6 @@ describe('typeEnumResolution', () => {
{successful: true, type: 'enum', name: 'Foo'},
true /* nullable */,
'SomeModule' /* name */,
'Flow',
enumMap,
parser,
);
Expand Down
5 changes: 1 addition & 4 deletions packages/react-native-codegen/src/parsers/flow/modules/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ const {
throwIfPartialWithMoreParameter,
} = require('../../error-utils');

const language = 'Flow';

function translateTypeAnnotation(
hasteModuleName: string,
/**
Expand Down Expand Up @@ -295,7 +293,6 @@ function translateTypeAnnotation(
typeResolutionStatus,
nullable,
hasteModuleName,
language,
enumMap,
parser,
);
Expand All @@ -304,7 +301,7 @@ function translateTypeAnnotation(
throw new UnsupportedTypeAnnotationParserError(
hasteModuleName,
typeAnnotation,
language,
parser.language(),
);
}
}
Expand Down
4 changes: 1 addition & 3 deletions packages/react-native-codegen/src/parsers/parsers-primitives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ import type {
NativeModuleObjectTypeAnnotation,
NativeModuleEnumDeclaration,
} from '../CodegenSchema';
import type {ParserType} from './errors';
import type {Parser} from './parser';
import type {
ParserErrorCapturer,
Expand Down Expand Up @@ -204,15 +203,14 @@ function typeEnumResolution(
typeResolution: TypeResolutionStatus,
nullable: boolean,
hasteModuleName: string,
language: ParserType,
enumMap: {...NativeModuleEnumMap},
parser: Parser,
): Nullable<NativeModuleEnumDeclaration> {
if (!typeResolution.successful || typeResolution.type !== 'enum') {
throw new UnsupportedTypeAnnotationParserError(
hasteModuleName,
typeAnnotation,
language,
parser.language(),
);
}

Expand Down
5 changes: 1 addition & 4 deletions packages/react-native-codegen/src/parsers/typescript/modules/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ const {
throwIfPartialWithMoreParameter,
} = require('../../error-utils');

const language = 'TypeScript';

function translateObjectTypeAnnotation(
hasteModuleName: string,
/**
Expand Down Expand Up @@ -362,7 +360,6 @@ function translateTypeAnnotation(
typeResolutionStatus,
nullable,
hasteModuleName,
language,
enumMap,
parser,
);
Expand Down Expand Up @@ -406,7 +403,7 @@ function translateTypeAnnotation(
throw new UnsupportedTypeAnnotationParserError(
hasteModuleName,
typeAnnotation,
language,
parser.language(),
);
}
}
Expand Down