Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Ruby Pinning from 0.70 #36422

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Conversation

cipolleschi
Copy link
Contributor

Summary

Starting from 0.72, we won't be pin any specific ruby version. However, 0.70 and 0.71 are still doing that.
This PR against 0.70, removes the pinning of a specific version of Ruby

Changelog

[iOS][Changed] - Do not pin a specific version of Ruby.

Test Plan

  • CircleCI should stay green

@react-native-bot react-native-bot added the Platform: iOS iOS applications. label Mar 9, 2023
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 9, 2023
Gemfile Outdated

gem 'cocoapods', '~> 1.11', '>= 1.11.2'
gem 'cocoapods', '~> 1.12'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headsup, we're "bumping" cocoapods for everyone by doing this - are we sure we want it? is there a way we can be >= 1.11?

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: bcec590
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,596,784 -918,613
android hermes armeabi-v7a 7,015,313 -815,972
android hermes x86 7,898,004 -1,097,717
android hermes x86_64 7,869,808 -981,389
android jsc arm64-v8a 9,478,198 +338,169
android jsc armeabi-v7a 8,258,794 -72,834
android jsc x86 9,417,524 +222,535
android jsc x86_64 10,008,773 +555,677

Base commit: bcec590
Branch: main

@cipolleschi
Copy link
Contributor Author

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants