Prepare to break the Dependency Cycle between React-graphics and React-Fabric #36385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-Fabric Summary: This change moves the `graphics/conversions.h` files from `ReactCommon/react/renderer/graphics` to `ReactCommon/react/renderer/core`, renaming it to `graphicsConversions.h`. This is required because React-Fabric imports graphics, but graphics imports React-Fabric due to this file. The change would be breaking, but we don't want to break the ecosystem without even a warning. So, we put back the `conversions.h` file, which now just `include` the new one and outputs a warning when building. This actually maintain the dep cycle for the current version, but at least users are warned. ## Changelog: [iOS][Deprecated] - Deprecate the `ReactCommon/react/renderer/graphics/conversions.h` in favor of `ReactCommon/react/core/graphicsConversions.h` Reviewed By: dmytrorykun Differential Revision: D43836261 fbshipit-source-id: d9090f6ab0b3037c3e1cd2c3dbcf549d2aa40e84
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43836261 |
Base commit: d00c150 |
|
This pull request has been merged in d72697c. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…t-Fabric (facebook#36385) Summary: Pull Request resolved: facebook#36385 This change moves the `graphics/conversions.h` files from `ReactCommon/react/renderer/graphics` to `ReactCommon/react/renderer/core`, renaming it to `graphicsConversions.h`. This is required because React-Fabric imports graphics, but graphics imports React-Fabric due to this file. The change would be breaking, but we don't want to break the ecosystem without even a warning. So, we put back the `conversions.h` file, which now just `include` the new one and outputs a warning when building. This actually maintain the dep cycle for the current version, but at least users are warned. ## Changelog: [iOS][Deprecated] - Deprecate the `ReactCommon/react/renderer/graphics/conversions.h` in favor of `ReactCommon/react/core/graphicsConversions.h` Reviewed By: cortinico, dmytrorykun Differential Revision: D43836261 fbshipit-source-id: ffe53a8ce2b0ea2dd1e1e5aaf6b3d3c5b57ad46d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change moves the
graphics/conversions.hfiles fromReactCommon/react/renderer/graphicstoReactCommon/react/renderer/core, renaming it tographicsConversions.h.This is required because React-Fabric imports graphics, but graphics imports React-Fabric due to this file.
The change would be breaking, but we don't want to break the ecosystem without even a warning. So, we put back the
conversions.hfile, which now justincludethe new one and outputs a warning when building. This actually maintain the dep cycle for the current version, but at least users are warned.Changelog:
[iOS][Deprecated] - Deprecate the
ReactCommon/react/renderer/graphics/conversions.hin favor ofReactCommon/react/core/graphicsConversions.hReviewed By: dmytrorykun
Differential Revision: D43836261