Fixes JSDoc in Cliapboard setString #36381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: d00c150 |
cortinico
requested changes
Mar 6, 2023
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 0ecb4e6. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: There was a JSDoc mismatch in `Clipboard.setString` method, `the` was considered as a parameter name, not `content`. Added correct param name and kept the same description as before, separated with a hyphen. ## Changelog [GENERAL] [FIXED] - Fixes JSDoc in Cliapboard setString Pull Request resolved: facebook#36381 Test Plan: No tests needed Reviewed By: yungsters Differential Revision: D43839086 Pulled By: cortinico fbshipit-source-id: 126035d9796e66938402704eaf9bc8646ee9b78b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a JSDoc mismatch in
Cliapboard.setStringmethod,thewas considered as a parameter name, notcontent. Added correct param name and kept the same description as before, separated with a hyphen.Changelog
[GENERAL] [FIXED] - Fixes JSDoc in Cliapboard setString
Test Plan
No tests needed