[Codegen 77] Extract the functions to compute partial properties in the Flow and TypeScript parsers. #36373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
MaeIg
changed the title
MaeIg
force-pushed
the
refactor/extract-function-partial-properties
branch
from
ba9e359 to
70abd30
Compare
|
@MaeIg Could you please add tests for that as well? |
Base commit: 24dbb5d |
MaeIg
force-pushed
the
refactor/extract-function-partial-properties
branch
from
70abd30 to
9f5bf40
Compare
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
rshest
reviewed
Mar 7, 2023
Comment on lines
+189
to
+195
| * @paramater properties: properties from a Partial types. | ||
| * @parameter hasteModuleName: a string with the native module name. | ||
| * @paramater types: a map of type declarations. | ||
| * @paramater aliasMap: a map of type aliases. | ||
| * @paramater enumMap: a map of type enums. | ||
| * @paramater tryParse: a parser error capturer. | ||
| * @paramater cxxOnly: a boolean specifying if the module is Cxx only. |
There was a problem hiding this comment.
Ups sorry for the typo!
I see that you fixed the typo and merged the PR, thank you! :)
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ypeScript parsers. (facebook#36373) Summary: This PR aims to extract the switch(configType) block from the buildSchema function into a separate function in a shared file between typescript and flow. It is a task of facebook#34872: > [Codegen 77 - assigned to MaeIg] Extract the functions to compute partial properties from the index.js file ([Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/modules/index.js#L180-L194) and [TypeScript](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L261-L278))in the Flow and TypeScript parsers. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract the functions to compute partial properties in the Flow and TypeScript parsers. Pull Request resolved: facebook#36373 Test Plan: yarn flow: <img width="560" alt="image" src="https://user-images.githubusercontent.com/40902940/222934040-97e88691-c1d6-44a1-b7ee-e500b4698cd2.png"> yarn lint: <img width="509" alt="image" src="https://user-images.githubusercontent.com/40902940/222934137-05b6f1fd-a755-4323-baac-5954d36fd613.png"> yarn test <img width="388" alt="image" src="https://user-images.githubusercontent.com/40902940/222934145-76a2bc38-7469-4c30-9301-bc21cfadded4.png"> Reviewed By: cipolleschi Differential Revision: D43867937 Pulled By: rshest fbshipit-source-id: f78fe399ff7d7d2cf8f44d1165418566b0a25628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to extract the switch(configType) block from the buildSchema function into a separate function in a shared file between typescript and flow. It is a task of #34872:
Changelog
[Internal] [Changed] - Extract the functions to compute partial properties in the Flow and TypeScript parsers.
Test Plan
yarn flow:
yarn lint:
yarn test
