Remove the enableSeparateBuildPerCPUArchitecture from the template entirely

[cortinico]

Summary:
See react-native-community/discussions-and-proposals#602 for more context.
TL;DR: this flag is used for an edge case. We should not expose it to every users but move it to a guide.

I'll publish a guide on the website on how to achieve the same feature.

Changelog:
[Android] [Changed] - Remove the enableSeparateBuildPerCPUArchitecture from the template entirely

Reviewed By: cipolleschi

Differential Revision: D43695574

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D43695574

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,477,095	+0
android	hermes	armeabi-v7a	7,799,079	+0
android	hermes	x86	8,953,089	+0
android	hermes	x86_64	8,810,587	+0
android	jsc	arm64-v8a	9,108,176	+0
android	jsc	armeabi-v7a	8,304,844	+0
android	jsc	x86	9,159,032	+0
android	jsc	x86_64	9,418,319	+0

Base commit: 32931b7
Branch: main

[ecreeth]

@cortinico this is going to break this. Should we remove it?

[cortinico]

@cortinico this is going to break this. Should we remove it?

You're so right! Thanks for spotting this. Let me revert the change to RN Tester only so we have that information as well.

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D43695574

[facebook-github-bot]

This pull request has been merged in dadf74f.

[liamjones]

@cortinico I've just run across this while upgrading an app to 0.72 and have a question you might know the answer to...

Is reactNativeArchitectures in the template settings.gradle now redundant too?

react-native/packages/react-native/template/android/gradle.properties

Line 30 in b00569c

reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64

The code removed in this PR used to use it. The one reason I'm not sure if it's still needed is that there do seem to be references to it showing the repo: https://github.com/search?q=repo%3Afacebook%2Freact-native%20reactNativeArchitectures&type=code but they look very much like what was removed and may be redundant too?

[cortinico]

Is reactNativeArchitectures in the template settings.gradle now redundant too?

Do you mean the gradle.properties file (as that's one you linked)? No it's not redundant @liamjones

That property is used by the React Native Gradle Plugin to do ABI filtering when specified so we need to keep it

[liamjones]

Sorry, yes I did mean that file. Thanks for the confirmation it's still needed!