[fix] Use RNTester init also in the old arch when Fabric is enabled #36283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
force-pushed
the
fix/rn_tester_init
branch
from
a9a032c to
75f5a77
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 346b028 |
Contributor
|
@cipolleschi merged this pull request in bf03e86. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ok#36283) Summary: This PR fixes the initialization path of RNTester when it is run with the Old Arch and Fabric enabled ## Changelog [iOS][Fixed] - Make sure to initialize the contextContainer in the Old Arch with Fabric enabled Pull Request resolved: facebook#36283 Test Plan: Tested manually on RNTester CircleCI is green Reviewed By: sammy-SC Differential Revision: D43568205 Pulled By: cipolleschi fbshipit-source-id: cddba97629b542a044191da14221f3300a9d879f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the initialization path of RNTester when it is run with the Old Arch and Fabric enabled
Changelog
[iOS][Fixed] - Make sure to initialize the contextContainer in the Old Arch with Fabric enabled
Test Plan
Tested manually on RNTester
CircleCI is green