Skip to content

Conversation

@rshest
Copy link
Contributor

@rshest rshest commented Feb 24, 2023

Summary:
[Changelog][Internal]

The diff creates a test clause for TurboModule::emitDeviceEvent C++ API for TurboModules, which can be seen in either Catalyst or RNTester.

Reviewed By: cipolleschi

Differential Revision: D43466327

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43466327

@github-actions
Copy link

github-actions bot commented Feb 24, 2023

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 43ea08b

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43466327

rshest added a commit to rshest/react-native that referenced this pull request Feb 24, 2023
…6278)

Summary:
Pull Request resolved: facebook#36278

[Changelog][Internal]

The diff creates a test clause for [TurboModule::emitDeviceEvent C++ API for TurboModules](https://www.internalfb.com/code/fbsource/[929870c905c8fe68cb330ce96bda7eb703bb6ae6]/xplat/js/react-native-github/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h?lines=90), which can be seen in either Catalyst or RNTester.

Reviewed By: cipolleschi

Differential Revision: D43466327

fbshipit-source-id: 682c1522bf2245796605463fe67fc8aa6cce8eec
@analysis-bot
Copy link

analysis-bot commented Feb 24, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,461,188 +1,960
android hermes armeabi-v7a 7,784,348 +1,850
android hermes x86 8,937,371 +2,235
android hermes x86_64 8,794,312 +2,095
android jsc arm64-v8a 9,095,039 +1,949
android jsc armeabi-v7a 8,293,027 +1,838
android jsc x86 9,146,131 +2,228
android jsc x86_64 9,404,839 +2,074

Base commit: a7f962c
Branch: main

…6278)

Summary:
Pull Request resolved: facebook#36278

[Changelog][Internal]

The diff creates a test clause for [TurboModule::emitDeviceEvent C++ API for TurboModules](https://www.internalfb.com/code/fbsource/[929870c905c8fe68cb330ce96bda7eb703bb6ae6]/xplat/js/react-native-github/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h?lines=90), which can be seen in either Catalyst or RNTester.

Reviewed By: cipolleschi

Differential Revision: D43466327

fbshipit-source-id: e2fa63a84e74d1ed3d710d97131fc8f71d2b43ac
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43466327

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e106a62.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…6278)

Summary:
Pull Request resolved: facebook#36278

[Changelog][Internal]

The diff creates a test clause for [TurboModule::emitDeviceEvent C++ API for TurboModules](https://www.internalfb.com/code/fbsource/[929870c905c8fe68cb330ce96bda7eb703bb6ae6]/xplat/js/react-native-github/ReactCommon/react/nativemodule/core/ReactCommon/TurboModule.h?lines=90), which can be seen in either Catalyst or RNTester.

Reviewed By: cipolleschi

Differential Revision: D43466327

fbshipit-source-id: ff4c111b4beaab72b13d2bd89ed03023c9c7b3cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants