Gradle 8.x prep - specify task dependency between mergeNativeLibs and external native builds #36253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43501128 |
…erated|intermediate]**` Summary: I'm widening the exclude for GenerateCodegenSchemaTask input files. This is needed before we can migrate to Gradle 8.x as one of the build warning we have is now converted to a build failure. The reason why this is needed is because GenerateCodegenSchemaTask ends up picking up a file that gets generated by `react-native bundle`. While the file is ignored by the Codegen, Gradle detects a clash between the two tasks. This solves the issue completely. Changelog: [Internal] [Changed] - RNGP - GenerateCodegenSchemaTask should exclude all of `**/build/[generated|intermediate]**` Differential Revision: D43501129 fbshipit-source-id: 84b267428b342002b678f0c485cb8f2925f85950
… external native builds (facebook#36253) Summary: Pull Request resolved: facebook#36253 Another build warning that got converted into a failure in Gradle 8.x Specifically here as we're running 4 native builds in parallel for RN Tester, but they all originate from 2 CMake intermediates files (one set for Debug and one for Release), Gradle raises a warning. Here I'm fixing this warning by specifying an explicit ordering between those tasks. Changelog: [Internal] [Changed] - Gradle 8.x prep - specify task dependency between mergeNativeLibs and external native builds Reviewed By: cipolleschi Differential Revision: D43501128 fbshipit-source-id: ebd5797b4c8cf7044515e9d9c59f8d146a3524e2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43501128 |
cortinico
force-pushed
the
export-D43501128
branch
from
a842827 to
f624998
Compare
Base commit: 62faa79 |
Contributor
|
This pull request has been merged in 2f81bb8. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
… external native builds (facebook#36253) Summary: Pull Request resolved: facebook#36253 Another build warning that got converted into a failure in Gradle 8.x Specifically here as we're running 4 native builds in parallel for RN Tester, but they all originate from 2 CMake intermediates files (one set for Debug and one for Release), Gradle raises a warning. Here I'm fixing this warning by specifying an explicit ordering between those tasks. Changelog: [Internal] [Changed] - Gradle 8.x prep - specify task dependency between mergeNativeLibs and external native builds Reviewed By: cipolleschi Differential Revision: D43501128 fbshipit-source-id: bb40ae902157ce97683f42124ec65f2bc0d73405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Another build warning that got converted into a failure in Gradle 8.x
Specifically here as we're running 4 native builds in parallel for RN Tester, but they all originate
from 2 CMake intermediates files (one set for Debug and one for Release), Gradle raises a warning.
Here I'm fixing this warning by specifying an explicit ordering between those tasks.
Changelog:
[Internal] [Changed] - Gradle 8.x prep - specify task dependency between mergeNativeLibs and external native builds
Reviewed By: cipolleschi
Differential Revision: D43501128