[Codegen 83] Merge Flow and TS Parsers' IncorrectModuleRegistryCallArgumentTypeParserError error-emitting code
#36252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peParserError` error-emitting code - into `throwIfIncorrectModuleRegistryCallArgument` fun in `error-utils.js`
facebook-github-bot
added
the
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 270584a |
Contributor
|
@cipolleschi merged this pull request in 1362820. |
Closed
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…peParserError` error-emitting code (facebook#36252) Summary: > [Codegen 83 - assigned to Pranav-yadav] Create a function throwIfIncorrectModuleRegistryCallArgumnent function in the errors.js file and factor together the code from [Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/modules/index.js#L407-L415) and [TypeScript](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/modules/index.js#L513-L521). Update the Parsers to return the right Literl type Merged `Flow` and `TS` Parsers' `IncorrectModuleRegistryCallArgumentTypeParserError` error-emitting code - into `throwIfIncorrectModuleRegistryCallArgument` fun in `error-utils.js` ## Changelog [INTERNAL] [CHANGED] - Merge `Flow` and `TS` Parsers' `IncorrectModuleRegistryCallArgumentTypeParserError` error-emitting code Pull Request resolved: facebook#36252 Test Plan: - `yarn test` Reviewed By: rshest Differential Revision: D43502843 Pulled By: cipolleschi fbshipit-source-id: eb63b40d433f90134a80c02c8f750257c82104a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merged
FlowandTSParsers'IncorrectModuleRegistryCallArgumentTypeParserErrorerror-emitting codethrowIfIncorrectModuleRegistryCallArgumentfun inerror-utils.jsChangelog
[INTERNAL] [CHANGED] - Merge
FlowandTSParsers'IncorrectModuleRegistryCallArgumentTypeParserErrorerror-emitting codeTest Plan
yarn test