[Codegen 74] Replace getTypes functions with parser specific methods #36225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
AntoineDoubovetzky
changed the title
Base commit: 05438c3 |
Contributor
|
Thanks for taking the time to run this refactoring! |
cipolleschi
approved these changes
Feb 21, 2023
cipolleschi
changed the title
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@AntoineDoubovetzky FYI, this task is 74, not 84 😁 |
AntoineDoubovetzky
changed the title
Author
|
Oh sorry, I updated the description |
Contributor
|
@AntoineDoubovetzky could you please rebase and fix the merge conflicts, please? Now that we have a few people working on Codegen, they will be quite common.. 😅 |
AntoineDoubovetzky
force-pushed
the
refactor/move-getTypes-to-parsers
branch
from
160f5ba to
abe3cad
Compare
Author
|
@cipolleschi It's done! |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in f23f7f4. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This PR is task 74 from facebook#34872: > Move getTypes functions from utils.js to specific Parsers. Right now we have two Parser classes that takes care of the language specific details and two utils files that contains similar logic. We would like to move everything under the Parsers classes for better OOP architecture and to encourage code-reuse. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Replace getTypes functions with parser specific methods Pull Request resolved: facebook#36225 Test Plan: I tested using Jest and Flow commands. Reviewed By: rshest Differential Revision: D43453454 Pulled By: cipolleschi fbshipit-source-id: 0eebcb55e1af3319e2c35bb462980046329a2c09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is task 74 from #34872:
Changelog
[Internal] [Changed] - Replace getTypes functions with parser specific methods
Test Plan
I tested using Jest and Flow commands.