Missing src, srcSet, referrerPolicy, tintColor on Image.d.ts #36214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
Please consider adding a test plan, otherwise looks reasonable. |
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
sure, thank for your feedbacks :) i updated my previous message with the test plan. |
rshest
approved these changes
Feb 22, 2023
alvessteve
force-pushed
the
missing-props-image
branch
from
73d7940 to
9c9e2de
Compare
Contributor
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…k#36214) Summary: After reviewing the doc [`Image`](https://reactnative.dev/docs/image), the typescript compiler doesn't know the following properties: - src - srcSet - referrerPolicy - tintColor - objectFit But after reviewing the source code and this [`commit`](facebook@b2452ab), the `objectFit` property isn't one related to the Image component but to the `style` props, making the official doc outdated. So, an [`issue in the react-native-website repo`](facebook/react-native-website#3579) have been created and I decided to not include the objectFit prop in this PR. So, this PR includes those properties: sec, secSet, referrerPolicy and tintColor ## Changelog [GENERAL][FIXED] Add src, srcSet, referrerPolicy, tintColor to Image.d.ts declaration file Pull Request resolved: facebook#36214 Reviewed By: NickGerleman Differential Revision: D43437894 Pulled By: rshest fbshipit-source-id: 497426490134aba0a474c49bf8bab9131f2e5845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After reviewing the doc
Image, the typescript compiler doesn't know the following properties:But after reviewing the source code and this
commit, theobjectFitproperty isn't one related to the Image component but to thestyleprops, making the official doc outdated. So, anissue in the react-native-website repohave been created and I decided to not include the objectFit prop in this PR.So, this PR includes those properties: sec, secSet, referrerPolicy and tintColor
Changelog
[GENERAL][FIXED] Add src, srcSet, referrerPolicy, tintColor to Image.d.ts declaration file
Test Plan
To test it, create/use a typescript file and call the
Imagecomponent. Then, check if the autocompletion provides you the right properties with the right type. For example, for the referrerPolicy one: