-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS] Add smartInsertDelete prop to TextInput component #36111
Closed
fabioh8010
wants to merge
3
commits into
facebook:main
from
fabioh8010:feature/text-input-ios-autoformatting-behaviors
Closed
[IOS] Add smartInsertDelete prop to TextInput component #36111
fabioh8010
wants to merge
3
commits into
facebook:main
from
fabioh8010:feature/text-input-ios-autoformatting-behaviors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Feb 9, 2023
Base commit: e449706 |
2 tasks
Nice improvement! 😍 |
This was referenced Feb 9, 2023
Great! |
This was referenced Feb 10, 2023
NickGerleman
approved these changes
Jun 5, 2023
@fabioh8010 could you rebase? |
fabioh8010
force-pushed
the
feature/text-input-ios-autoformatting-behaviors
branch
from
June 7, 2023 15:04
afb2f95
to
8fc4331
Compare
@NickGerleman done! |
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@NickGerleman merged this pull request in 6b62f12. |
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR add support to configure the
smartInsertDeleteType
property in iOS inputs as described here, making possible toggle this autoformatting behavior.PR for the docs update: facebook/react-native-website#3560
Changelog:
[IOS] [ADDED] - Add
smartInsertDelete
prop toTextInput
componentTest Plan:
smartInsertDelete
prop istrue
orundefined
, the system will use the default autoformatting behavior.smartInsertDelete
prop isfalse
, the system will disable the autoformatting behavior.Simulator.Screen.Recording.-.iPhone.14.-.2023-02-09.at.15.40.07.mp4