Skip to content

Fix incorrect touchable hitSlop and pressRetentionOffset type #36065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix incorrect touchable hitSlop and pressRetentionOffset type #36065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d7abcf
Fix: incorrect touchable hitSlop type
bigcupcoffee Feb 6, 2023
b18984d
Fix pressRetentionOffset type as well
bigcupcoffee Feb 8, 2023
ada9983
Sync flow types to TS declaration
bigcupcoffee Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Libraries/Components/Touchable/TouchableWithoutFeedback.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export interface TouchableWithoutFeedbackProps
* the Z-index of sibling views always takes precedence if a touch hits
* two overlapping views.
*/
hitSlop?: Insets | undefined;
hitSlop?: null | Insets | number | undefined;

/**
* Used to reference react managed views from native code.
Expand Down Expand Up @@ -121,7 +121,7 @@ export interface TouchableWithoutFeedbackProps
* while the scroll view is disabled. Ensure you pass in a constant
* to reduce memory allocations.
*/
pressRetentionOffset?: Insets | undefined;
pressRetentionOffset?: null | Insets | number | undefined;

/**
* Used to locate this view in end-to-end tests.
Expand Down
6 changes: 3 additions & 3 deletions Libraries/Components/Touchable/TouchableWithoutFeedback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import type {
AccessibilityState,
AccessibilityValue,
} from '../../Components/View/ViewAccessibility';
import type {EdgeInsetsProp} from '../../StyleSheet/EdgeInsetsPropType';
import type {EdgeInsetsOrSizeProp} from '../../StyleSheet/EdgeInsetsPropType';
import type {
BlurEvent,
FocusEvent,
Expand Down Expand Up @@ -67,7 +67,7 @@ type Props = $ReadOnly<{|
delayPressOut?: ?number,
disabled?: ?boolean,
focusable?: ?boolean,
hitSlop?: ?EdgeInsetsProp,
hitSlop?: ?EdgeInsetsOrSizeProp,
id?: string,
importantForAccessibility?: ?('auto' | 'yes' | 'no' | 'no-hide-descendants'),
nativeID?: ?string,
Expand All @@ -79,7 +79,7 @@ type Props = $ReadOnly<{|
onPress?: ?(event: PressEvent) => mixed,
onPressIn?: ?(event: PressEvent) => mixed,
onPressOut?: ?(event: PressEvent) => mixed,
pressRetentionOffset?: ?EdgeInsetsProp,
pressRetentionOffset?: ?EdgeInsetsOrSizeProp,
rejectResponderTermination?: ?boolean,
testID?: ?string,
touchSoundDisabled?: ?boolean,
Expand Down