Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate role grid from RCTViewManager #35932

Closed

Conversation

fabOnReact
Copy link
Contributor

@fabOnReact fabOnReact commented Jan 23, 2023

Summary

Fix warning: duplicate key in dictionary literal. Different PRs tried to fix this issue at the same time and introduced a duplicate. Related fabOnReact@55c0df4 fabOnReact@f3d9f2e

Changelog

[IOS] [FIXED] - remove duplicate role grid from RCTViewManager

Test Plan

duplicated grid role on iOS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2023
@fabOnReact fabOnReact marked this pull request as ready for review January 23, 2023 13:54
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,461,687 +0
android hermes armeabi-v7a 7,782,266 +0
android hermes x86 8,934,961 +0
android hermes x86_64 8,793,021 +0
android jsc arm64-v8a 9,647,905 +0
android jsc armeabi-v7a 8,382,400 +0
android jsc x86 9,710,156 +0
android jsc x86_64 10,187,164 +0

Base commit: 1bab3e2
Branch: main

@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 23, 2023
@facebook-github-bot
Copy link
Contributor

@jacdebug merged this pull request in 49d5277.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Fix warning: duplicate key in dictionary literal. Different PRs tried to fix this issue at the same time and introduced a duplicate. Related fabOnReact@55c0df4 fabOnReact@f3d9f2e

## Changelog

[IOS] [FIXED] - remove duplicate role grid from RCTViewManager

Pull Request resolved: facebook#35932

Test Plan: <img width="1920" alt="duplicated grid role on iOS" src="https://user-images.githubusercontent.com/24992535/214054716-d79dec11-2b5c-4780-a4af-08d50be4a1a2.png">

Reviewed By: sammy-SC

Differential Revision: D42677641

Pulled By: jacdebug

fbshipit-source-id: f3eaa99ce89d7f9602843fde0dc0f371300e7052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants