fix(scripts): add logic for version scripts to account for local E2E test versioning #35847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Jan 16, 2023
Co-authored-by: Riccardo <cipolleschi@fb.com>
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
…test versioning (#35846) Summary: While working on 0.71 branch I encountered a problem in testing locally. Basically, I was getting hit by a silent error caused by recent work #35296 that didn't account for the shape of E2E local script for the release, `0.71.0-20230116-1649`. This scripts fixes both aspects: the error now gets thrown "better" and the logic accounts for the E2E shape. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [FIXED] - add logic for version scripts to account for local E2E test versioning Pull Request resolved: #35846 Test Plan: Tested via the other PR: #35847 Reviewed By: cortinico Differential Revision: D42543200 Pulled By: cipolleschi fbshipit-source-id: 727eb887fcbd183ec56d8a9b7e98241eaacb1d98
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…test versioning (facebook#35846) Summary: While working on 0.71 branch I encountered a problem in testing locally. Basically, I was getting hit by a silent error caused by recent work facebook#35296 that didn't account for the shape of E2E local script for the release, `0.71.0-20230116-1649`. This scripts fixes both aspects: the error now gets thrown "better" and the logic accounts for the E2E shape. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [INTERNAL] [FIXED] - add logic for version scripts to account for local E2E test versioning Pull Request resolved: facebook#35846 Test Plan: Tested via the other PR: facebook#35847 Reviewed By: cortinico Differential Revision: D42543200 Pulled By: cipolleschi fbshipit-source-id: 727eb887fcbd183ec56d8a9b7e98241eaacb1d98
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on this PR #35786 I encountered a problem in testing locally. Basically, I was getting hit by a silent error caused by recent work #35296 that didn't account for the shape of E2E local script for the release,
0.71.0-20230116-1649.This scripts fixes both aspects: the error now gets thrown "better" and the logic accounts for the E2E shape.
This is the PR for 0.71-stable branch, the one for main can be found here: #35846
Changelog
[INTERNAL] [FIXED] - add logic for version scripts to account for local E2E test versioning
Test Plan
Tested in this PR; here's how it will error now:
and if you try running
yarn test-e2e-local -t RNTestProject -p Androidnow it will go ahead and work 👍