Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UIKit import from RCTDevLoadingView.h #35843

Closed
wants to merge 1 commit into from
Closed

Remove UIKit import from RCTDevLoadingView.h #35843

wants to merge 1 commit into from

Conversation

christophpurrer
Copy link
Contributor

Summary:
See: microsoft#1604

Changelog:
[iOS][Fixed]: Remove UIKit import from RCTDevLoadingView.h

Differential Revision: D42529787

@christophpurrer @facebook-github-bot
Remove UIKit import from RCTDevLoadingView.h
6eab99c 
Summary:
See: microsoft#1604

Changelog:
[iOS][Fixed]: Remove UIKit import from RCTDevLoadingView.h

Differential Revision: D42529787

fbshipit-source-id: 4d694487e96947d2b94021319da53d7ff581257f
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jan 16, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42529787

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,464,873 +0
android hermes armeabi-v7a 7,785,604 +0
android hermes x86 8,938,342 +0
android hermes x86_64 8,796,410 +0
android jsc arm64-v8a 9,651,262 +0
android jsc armeabi-v7a 8,385,729 +0
android jsc x86 9,713,458 +0
android jsc x86_64 10,190,641 +0

Base commit: 8d2a629
Branch: main

@christophpurrer christophpurrer mentioned this pull request Jan 16, 2023
Closed
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e7dcad2.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@christophpurrer @OlimpiaZurek
Remove UIKit import from RCTDevLoadingView.h (facebook#35843)
17eb7aa 
Summary:
Pull Request resolved: facebook#35843

See: microsoft#1604

Changelog:
[iOS][Fixed]: Remove UIKit import from RCTDevLoadingView.h

Reviewed By: cipolleschi

Differential Revision: D42529787

fbshipit-source-id: 2a63574794a5c962a17b49fa46a146b1252a0445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophpurrer @facebook-github-bot @analysis-bot