Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting LoadingView change of native implementation of DevLoadingView #35744

Closed
wants to merge 1 commit into from
Closed

Reverting LoadingView change of native implementation of DevLoadingView #35744

wants to merge 1 commit into from

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
Changelog:
[Android][Fixed] - LoadingView of Android to use the Toast till the native implementation is functional

Differential Revision: D42284732

@arushikesarwani94 @facebook-github-bot
Reverting LoadingView change of native implementation of DevLoadingView
f51d84f 
Summary:
Changelog:
[Android][Fixed] - LoadingView of Android to use the Toast till the native implementation is functional

Differential Revision: D42284732

fbshipit-source-id: 096db63907da3a1cc935cf4f2f673431367905b5
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 29, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42284732

@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Dec 29, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 068a208
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,464,978 +0
android hermes armeabi-v7a 7,785,570 +0
android hermes x86 8,940,776 +0
android hermes x86_64 8,798,958 +0
android jsc arm64-v8a 9,652,079 +0
android jsc armeabi-v7a 8,386,299 +0
android jsc x86 9,716,461 +0
android jsc x86_64 10,193,883 +0

Base commit: 068a208
Branch: main

@pull-bot
Copy link

PR build artifact for f51d84f is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for f51d84f is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8ccb861.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@arushikesarwani94 @OlimpiaZurek
Reverting LoadingView change of native implementation of DevLoadingVi…
5079dd0 
…ew (facebook#35744)

Summary:
Pull Request resolved: facebook#35744

Changelog:
[Android][Fixed] - LoadingView of Android to use the Toast till the native implementation is functional

Reviewed By: lunaleaps

Differential Revision: D42284732

fbshipit-source-id: dc187e4602240f270b2fbfb40e47604e3a14415d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arushikesarwani94 @facebook-github-bot @analysis-bot @pull-bot @react-native-bot