[RNTester] Merge AlertIOSExample page into AlertExample page #35586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
4 tasks
Base commit: 5928144 |
Base commit: 5928144 |
|
PR build artifact for 641a419 is ready. |
|
PR build artifact for b186f91 is ready. |
|
PR build artifact for d1eced2 is ready. |
Saadnajmi
commented
Dec 7, 2022
NickGerleman
approved these changes
Dec 8, 2022
Contributor
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@NickGerleman merged this pull request in 76bf71e. |
Contributor
Author
Thank you! |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: `AlertIOS` was deprecated and removed long ago (facebook@e2bd7db) but there continues to be a test page with the name `AlertIOS` in RN-Tester. `AlertIOSExample.js` contains valid examples of how to use `Alert.prompt()` so it's worth keeping them around. Let's move those into `AlertExample.js` and remove `AlertIOSExample.js`. While we're here, let's do some extra fixes to the test page: - Remove `showsIndividualExamples = true`. For whatever reason, I needed to remove this to show the examples properly... - Convert all uses of `<TouchableHighlight>` with `<Pressable>`. The latter replaces the former, so I thought that made sense.. Some extra context: In React Native macOS, we had forked `AlertIOS` into `AlertMacOS`, with a corresponding example page. This PR was made while working on removing those (microsoft#1548). ## Changelog [INTERNAL] [CHANGED] - Moved `Alert.prompt` examples into common rn-tester test page Pull Request resolved: facebook#35586 Test Plan: Test page shows up fine on iOS .  Reviewed By: lunaleaps Differential Revision: D41825889 Pulled By: NickGerleman fbshipit-source-id: 82e4405b1f3a1ccb558b5a5038a90416e7a32c29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AlertIOSwas deprecated and removed long ago (e2bd7db) but there continues to be a test page with the nameAlertIOSin RN-Tester.AlertIOSExample.jscontains valid examples of how to useAlert.prompt()so it's worth keeping them around. Let's move those intoAlertExample.jsand removeAlertIOSExample.js. While we're here, let's do some extra fixes to the test page:showsIndividualExamples = true. For whatever reason, I needed to remove this to show the examples properly...<TouchableHighlight>with<Pressable>. The latter replaces the former, so I thought that made sense..Some extra context:
In React Native macOS, we had forked
AlertIOSintoAlertMacOS, with a corresponding example page. This PR was made while working on removing those (microsoft#1548).Changelog
[INTERNAL] [CHANGED] - Moved
Alert.promptexamples into common rn-tester test pageTest Plan
Test page shows up fine on iOS .