Read .ruby-version file in Gemfile
#35410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 81e441a |
Base commit: 81e441a |
|
PR build artifact for 3875a23 is ready. |
|
PR build artifact for 3875a23 is ready. |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kelset
pushed a commit
that referenced
this pull request
Nov 22, 2022
Summary: When updating the Ruby version, 2 files are always needed to be updated (`.ruby-version` and `Gemfile`). When not in sync it can lead to an error like `Your Ruby version is 2.7.6, but your Gemfile specified 2.7.5`. This lessens the files that need to be updated when upgrading the Ruby version and makes it in sync always. It makes the `.ruby-version` the source of truth. ### Example 1: <img width="481" alt="Screenshot 2022-11-20 at 13 56 08" src="https://user-images.githubusercontent.com/36528176/202888191-450ab6d0-32a4-4d37-ad82-0beb2b22fa82.png"> When upgrading from `0.70.0` to `0.71.0-rc.0`. 2 files needs to be updated when it could have been just 1. Source: https://react-native-community.github.io/upgrade-helper/?from=0.70.0&to=0.71.0-rc.0 ### Example 2: 21c8837 updates 4 files (`.ruby-version`, `Gemfile`, `template/Gemfile`, `template/_ruby-version`) when it could have been just 2. ### Other Sources: * https://andycroll.com/ruby/read-ruby-version-in-your-gemfile/ * https://render.com/docs/ruby-version (Heroku alternative) * https://stackoverflow.com/a/35823132/9375533 ## Changelog [General] [Changed] - Read `.ruby-version` file in `Gemfile` Pull Request resolved: #35410 Test Plan: Only `.ruby-version` and `template/_ruby-version` needs to be updated when upgrading Ruby version. Reviewed By: christophpurrer, cipolleschi Differential Revision: D41429147 Pulled By: rshest fbshipit-source-id: 9e541a1d84aed5dca1e6f465c61bb0ba15574211
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: When updating the Ruby version, 2 files are always needed to be updated (`.ruby-version` and `Gemfile`). When not in sync it can lead to an error like `Your Ruby version is 2.7.6, but your Gemfile specified 2.7.5`. This lessens the files that need to be updated when upgrading the Ruby version and makes it in sync always. It makes the `.ruby-version` the source of truth. ### Example 1: <img width="481" alt="Screenshot 2022-11-20 at 13 56 08" src="https://user-images.githubusercontent.com/36528176/202888191-450ab6d0-32a4-4d37-ad82-0beb2b22fa82.png"> When upgrading from `0.70.0` to `0.71.0-rc.0`. 2 files needs to be updated when it could have been just 1. Source: https://react-native-community.github.io/upgrade-helper/?from=0.70.0&to=0.71.0-rc.0 ### Example 2: 21c8837 updates 4 files (`.ruby-version`, `Gemfile`, `template/Gemfile`, `template/_ruby-version`) when it could have been just 2. ### Other Sources: * https://andycroll.com/ruby/read-ruby-version-in-your-gemfile/ * https://render.com/docs/ruby-version (Heroku alternative) * https://stackoverflow.com/a/35823132/9375533 ## Changelog [General] [Changed] - Read `.ruby-version` file in `Gemfile` Pull Request resolved: facebook#35410 Test Plan: Only `.ruby-version` and `template/_ruby-version` needs to be updated when upgrading Ruby version. Reviewed By: christophpurrer, cipolleschi Differential Revision: D41429147 Pulled By: rshest fbshipit-source-id: 9e541a1d84aed5dca1e6f465c61bb0ba15574211
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When updating the Ruby version, 2 files are always needed to be updated (
.ruby-versionandGemfile). When not in sync it can lead to an error likeYour Ruby version is 2.7.6, but your Gemfile specified 2.7.5.This lessens the files that need to be updated when upgrading the Ruby version and makes it in sync always. It makes the
.ruby-versionthe source of truth.Example 1:
When upgrading from
0.70.0to0.71.0-rc.0. 2 files needs to be updated when it could have been just 1.Source: https://react-native-community.github.io/upgrade-helper/?from=0.70.0&to=0.71.0-rc.0
Example 2:
21c8837 updates 4 files (
.ruby-version,Gemfile,template/Gemfile,template/_ruby-version) when it could have been just 2.Other Sources:
Changelog
[General] [Changed] - Read
.ruby-versionfile inGemfileTest Plan
Only
.ruby-versionandtemplate/_ruby-versionneeds to be updated when upgrading Ruby version.