-
Notifications
You must be signed in to change notification settings - Fork 24.8k
fix: RNTester TransformExample crash #35292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RNTester TransformExample crash #35292
Conversation
We should also make the failures yellowboxes not invariants |
Base commit: d07575b |
Base commit: d07575b |
@necolas should we use react-native/Libraries/StyleSheet/processTransform.js Lines 153 to 157 in bbb3a61
|
PR build artifact for bcba275 is ready. |
ah I forgot about that. hmm in which case let's just focus on merging this immediate fix. thanks for the context! |
@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: As pointed out by kelset on facebook#34660 (comment) accessing the `TransformExample` is currently crashing the `RNTester` app due to missing units in one of the transformers. This PR fixes it by updating the transform value to a valid string. ## Changelog [Internal] [Fixed] - Add missing translate units to `RNTester` `TransformExample` Pull Request resolved: facebook#35292 Test Plan: 1. Open the RNTester app and navigate to the Transforms page 2. Check the transform style through the `Transform using a string` section https://user-images.githubusercontent.com/11707729/200916399-779b2eeb-2bd8-4642-97a3-f050d6dd4278.mov Reviewed By: christophpurrer Differential Revision: D41164541 Pulled By: necolas fbshipit-source-id: 4aa62980001a6f8ccf0108cb3af1e573b67e02b1
Summary
As pointed out by @kelset on #34660 (comment) accessing the
TransformExample
is currently crashing theRNTester
app due to missing units in one of the transformers. This PR fixes it by updating the transform value to a valid string.Changelog
[Internal] [Fixed] - Add missing translate units to
RNTester
TransformExample
Test Plan
Transform using a string
sectionScreen.Recording.2022-11-09.at.15.53.00.mov