Skip to content

Conversation

gabrieldonadel
Copy link
Collaborator

Summary

As pointed out by @kelset on #34660 (comment) accessing the TransformExample is currently crashing the RNTester app due to missing units in one of the transformers. This PR fixes it by updating the transform value to a valid string.

Changelog

[Internal] [Fixed] - Add missing translate units to RNTester TransformExample

Test Plan

  1. Open the RNTester app and navigate to the Transforms page
  2. Check the transform style through the Transform using a string section
Screen.Recording.2022-11-09.at.15.53.00.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2022
@necolas
Copy link
Contributor

necolas commented Nov 9, 2022

We should also make the failures yellowboxes not invariants

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: d07575b
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,070,049 -31,730
android hermes armeabi-v7a 6,442,181 -29,401
android hermes x86 7,485,038 -34,271
android hermes x86_64 7,344,632 -33,223
android jsc arm64-v8a 8,934,559 -31,314
android jsc armeabi-v7a 7,668,665 -28,982
android jsc x86 8,994,609 -33,850
android jsc x86_64 9,473,539 -32,818

Base commit: d07575b
Branch: main

@gabrieldonadel
Copy link
Collaborator Author

We should also make the failures yellowboxes not invariants

@necolas should we use yellowboxes even though we only show this error when running on DEV mode? We also do this inside the _validateTransforms function, should we update that as well?

invariant(
keys.length === 1,
'You must specify exactly one property per transform object. Passed properties: %s',
stringifySafe(transformation),
);

@pull-bot
Copy link

pull-bot commented Nov 9, 2022

PR build artifact for bcba275 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@necolas
Copy link
Contributor

necolas commented Nov 9, 2022

even though we only show this error when running on DEV mode

ah I forgot about that. hmm in which case let's just focus on merging this immediate fix. thanks for the context!

@facebook-github-bot
Copy link
Contributor

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gabrieldonadel gabrieldonadel deleted the fix/rn-tester-transform-example branch November 9, 2022 21:58
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
As pointed out by kelset on facebook#34660 (comment) accessing the `TransformExample` is currently crashing the `RNTester` app due to missing units in one of the transformers. This PR fixes it by updating the transform value to a valid string.

## Changelog

[Internal] [Fixed] - Add missing translate units to  `RNTester` `TransformExample`

Pull Request resolved: facebook#35292

Test Plan:
1. Open the RNTester app and navigate to the Transforms page
2. Check the transform style through the `Transform using a string` section

https://user-images.githubusercontent.com/11707729/200916399-779b2eeb-2bd8-4642-97a3-f050d6dd4278.mov

Reviewed By: christophpurrer

Differential Revision: D41164541

Pulled By: necolas

fbshipit-source-id: 4aa62980001a6f8ccf0108cb3af1e573b67e02b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants