-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Hermes scripts: rename tarball methods to distinguish between source code and prebuilt artifacts #35156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was exported from Phabricator. Differential Revision: D40812290 |
Base commit: 76c7cca |
Base commit: 76c7cca |
PR build artifact for 4fad965 is ready. |
PR build artifact for 4fad965 is ready. |
…code and prebuilt artifacts (facebook#35156) Summary: Pull Request resolved: facebook#35156 There are two tarballs: the source code for Hermes that is downloaded from GitHub, and the hermes-runtime-darwin-{}-v{}.tar.gz tarball with prebuilt artifacts that is built in CI. Renamed some methods to make it clearer which tarball they work with. Changelog: [internal] Reviewed By: cipolleschi, dmytrorykun Differential Revision: D40812290 fbshipit-source-id: a34c2231134cf490df511bb6ba91290270c50ccb
This pull request was exported from Phabricator. Differential Revision: D40812290 |
4fad965
to
b98d831
Compare
PR build artifact for b98d831 is ready. |
PR build artifact for b98d831 is ready. |
This pull request was successfully merged by @hramos in 8f124be. When will my fix make it into a release? | Upcoming Releases |
…code and prebuilt artifacts (facebook#35156) Summary: Pull Request resolved: facebook#35156 There are two tarballs: the source code for Hermes that is downloaded from GitHub, and the hermes-runtime-darwin-{}-v{}.tar.gz tarball with prebuilt artifacts that is built in CI. Renamed some methods to make it clearer which tarball they work with. Changelog: [internal] Reviewed By: cipolleschi, dmytrorykun Differential Revision: D40812290 fbshipit-source-id: a2c865e1d1461829fe8d468f52deeb55f3565cb0
Summary:
There are two tarballs: the source code for Hermes that is downloaded from GitHub, and the hermes-runtime-darwin-{}-v{}.tar.gz tarball with prebuilt artifacts that is built in CI.
Renamed some methods to make it clearer which tarball they work with.
Changelog: [internal]
Reviewed By: cipolleschi, dmytrorykun
Differential Revision: D40812290