-
Notifications
You must be signed in to change notification settings - Fork 25k
extracted buildModuleSchema in parsers-common.js #35147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extracted buildModuleSchema in parsers-common.js #35147
Conversation
Base commit: ad5e3f6 |
Base commit: ad5e3f6 |
|
PR build artifact for 54ba9e5 is ready. |
|
Hi @dakshbhardwaj, thank you for taking this. Just a question: are you sure you added/committed all the changes? I can see the new function in the |
|
PR build artifact for 54ba9e5 is ready. |
Hi @cipolleschi i haven't removed it from the other files because this pr has dependency from the other tasks as some other functions are also needed to be moved to |
|
Hey @dakshbhardwaj ! Just heads up, the dependent changes (for this PR) are merged :) |
|
@dakshbhardwaj could you please rebase on top of |
|
gentle ping to @dakshbhardwaj, are you still interested working on this? |
|
Closing this as the author is not responsive. |
Summary
This PR is a task from #34872
Changelog
[Internal] [Changed] - Extract the function isModuleRegistryCall in parsers-common.js
Test Plan
I tested using Jest and Flow commands.